Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document this library's approach to GitHub API rate limit #601

Open
PauloMigAlmeida opened this issue Nov 9, 2019 · 2 comments
Open

Document this library's approach to GitHub API rate limit #601

PauloMigAlmeida opened this issue Nov 9, 2019 · 2 comments

Comments

@PauloMigAlmeida
Copy link
Contributor

Even for people that know certain bits and pieces of this library's source code, it still not trivial to understand how this library deals with GitHub's API rate limit.

I'm planning to write something about it as soon as the #595 is merged (as it may introduce the custom api rates)

@PauloMigAlmeida PauloMigAlmeida changed the title Document this library approach to rate limit Document this library's approach to rate limit Nov 9, 2019
@PauloMigAlmeida PauloMigAlmeida changed the title Document this library's approach to rate limit Document this library's approach to GitHub API rate limit Nov 9, 2019
@Hronom
Copy link

Hronom commented Oct 3, 2024

Please do this, we need to use rate limit and make client wait if it about to hit them

@bitwiseman
Copy link
Member

@Hronom

Help would be appreciated.

There is the rate limit checker and the abuse limit checker. More recently, GitHub has added more ephemeral rate limiting they call secondary rate limiting. It behaves somewhere like abuse limiting, the metric is not publicly reported on an API level, but clients are expected to adhere to it anyway. 😭 😡

I've filed #1975 to track work on improving the secondary rate limiting behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants