New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate over-long reason instead of dropping #381

Open

armanbilge opened this issue Sep 23, 2024 · 0 comments

Labels

enhancement good first issue

Member

armanbilge commented Sep 23, 2024

http4s-dom/dom/src/main/scala/org/http4s/dom/WebSocketClient.scala

Lines 102 to 107 in 5a7d490

    
           // reason must be no longer than 123 bytes of UTF-8 text 
        
           // UTF-8 character is max 4 bytes so we can fast-path 
        
           if (reason.length <= 30 || reason.getBytes.length <= 123) 
        
             Some(reason) 
        
           else 
        
             None

armanbilge added enhancement good first issue labels

armanbilge changed the title ~~Truncate over-long message instead of dropping~~ Truncate over-long reason instead of dropping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment