Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snappy encoding is actually not infallible #27

Open
gdesmott opened this issue Dec 11, 2023 · 0 comments
Open

snappy encoding is actually not infallible #27

gdesmott opened this issue Dec 11, 2023 · 0 comments

Comments

@gdesmott
Copy link
Contributor

I got this crash when my app was generating lots of logs: snappy encoding is infallible: TooBig { given: 4894810188, max: 4294967295 }

According to the snappy documentation encode() can actually fail if the input is too big.

I think tracing-loki should not panic in such case but just ignore the logs. And maybe log a warning?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdesmott