Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies versions #1

Open
denzp opened this issue Apr 7, 2022 · 2 comments
Open

Dependencies versions #1

denzp opened this issue Apr 7, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@denzp
Copy link

denzp commented Apr 7, 2022

Hello, first of all, thank you for creating this crate!
Do you have a specific reason to use such specific versions in the Cargo.toml?

I'd suggest the requirement can be relaxed a bit for crates that have a proper semantic versioning workflow. From:

...
tokio = { version = "1.17.0", features = ["sync"] }
tokio-stream = "0.1.8"
tracing = "0.1.32"
...

To:

...
tokio = { version = "1", features = ["sync"] }
tokio-stream = "0.1"
tracing = "0.1"
...

This gives downstream crates a little bit of leeway about shared dependencies.

Would you consider reviewing a PR addressing this?

@greaka
Copy link
Contributor

greaka commented Apr 12, 2022

@hrxi
Copy link
Owner

hrxi commented Apr 20, 2022

Sorry for responding late, I was on vacation.

Do you have a specific reason to use such specific versions in the Cargo.toml?

No, only that I haven't tested older versions.

This gives downstream crates a little bit of leeway about shared dependencies.

I agree that this is desirable.

Would you consider reviewing a PR addressing this?

Yes. It would be nice if the minimal versions were also tested in the CI somehow, maybe by the -Z minimal-versions flag of Cargo: See e.g. rust-lang/cargo#5657 or bheisler/criterion.rs#183.

@hrxi hrxi added the help wanted Extra attention is needed label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants