Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with siunitx v3 #28

Open
sieversMartin opened this issue Jun 27, 2021 · 5 comments
Open

Incompatibility with siunitx v3 #28

sieversMartin opened this issue Jun 27, 2021 · 5 comments

Comments

@sieversMartin
Copy link

The class makes use of some features not available in v3 of siunitx. This leads to some errors, and warnungs, e.g:

! Undefined control sequence.
<argument> \SendSettingsToPgf 
...

Package siunitx Warning: Option "round-integer-to-decimal" has been removed in
(siunitx)                this release.

Package siunitx Info: Option "group-digits = true" has been deprecated in this
(siunitx)             release.
(siunitx)             
(siunitx)             Use "group-digits = all" as a replacement.

A straightforward fix (or at least a workaround) is to load the old version with \RequirePackage{siunitx}[=v2]

@krono
Copy link
Member

krono commented Jun 27, 2021

This is true and probably I should have anticipated that…
Maybe a guard via latexrelease is in oder.

A workaround is passing the option before \documentclass

@krono
Copy link
Member

krono commented Jun 28, 2021

what is the best way to detect the presence of v3 before loading the file?

@sieversMartin
Copy link
Author

What about \@ifpackagelater{siunitx}{2021-04-17}{\RequirePackage{siuntix}[=v2]}{\RequirePackage{siunitx}}.

2021-04-17 is the release date of the last v2 version.

However, according to the documentation, loading the package with [=v2] should work for all installations:

This approach will work with older systems which still have version 2 installed, mean-
ing that you can reliably use it to work between systems with different versions of
siunitx.

@krono
Copy link
Member

krono commented Jun 28, 2021

The first won't work because (to my knowledge) this only works after loading a package.

The second is quite interesting!

@krono
Copy link
Member

krono commented Jun 28, 2021

FWIW, Fixing the errors and using the ifpackagelater-variant is the better way…

krono added a commit that referenced this issue Oct 5, 2021
it's 3.0 in 2021 or so and we still use the 2 interface.
also don't use the PGF interface deprecated in 3.0, I think we did not
use it after all.

see #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants