Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI Workflow #19

Closed
tri-adam opened this issue Apr 25, 2019 · 0 comments · Fixed by #20
Closed

Improve CI Workflow #19

tri-adam opened this issue Apr 25, 2019 · 0 comments · Fixed by #20
Assignees
@tri-adam
Labels
enhancement New feature or request

Comments

@tri-adam
Copy link
Contributor

There are some recommendations about how best to pass around source code and dependencies on the CircleCI blog. Use checkout to retrieve source, and restore_cache to fetch cached Go modules.

The check_formatting and vet_source jobs can be folded into lint_source, since golangci-lint is capable of running these tools.

Strongly believe we should also be reporting code coverage (even if it's unflattering before #5 is actioned.)
@tri-adam tri-adam added the enhancement New feature or request label Apr 25, 2019
@tri-adam tri-adam self-assigned this Apr 25, 2019
@tri-adam tri-adam mentioned this issue Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tri-adam tri-adam

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve CI Workflow
1 participant
@tri-adam