Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Add versions to requirements.txt #20

Open
bkmgit opened this issue Aug 2, 2022 · 5 comments
Open

Add versions to requirements.txt #20

bkmgit opened this issue Aug 2, 2022 · 5 comments

Comments

@bkmgit
Copy link
Contributor

bkmgit commented Aug 2, 2022

Adding version of libraries supported and tested on to requirements.txt will make setup easier. It would also allow running CI to check that the scripts used work. This is motivated by dropping of dropping of collections.MutableMapping from Python 3.10 and above, see https://stackoverflow.com/questions/70943244/attributeerror-module-collections-has-no-attribute-mutablemapping

@bkmgit
Copy link
Contributor Author

bkmgit commented Aug 2, 2022

@tkphd tkphd added the hackathon label Aug 4, 2022
@ocaisa
Copy link
Member

ocaisa commented Aug 4, 2022

I don't know what to do about this. Where is the requirement for collections coming from (it's not amdahl, unless that is indirectly via mpi4py which is it's only dependency).

@ocaisa
Copy link
Member

ocaisa commented Aug 4, 2022

Ah, it is from https://github.com/carpentries-incubator/hpc-workflows/blob/gh-pages/code/plotcount.py#L8 so that makes me worry less about this. I believe we have a pretty simple use case and we'll need to rewrite that file anyway so I suspect this requirement will disappear.

@ocaisa
Copy link
Member

ocaisa commented Aug 4, 2022

In general, this is a good idea, we should maintain a requirements.txt

@bkmgit
Copy link
Contributor Author

bkmgit commented Aug 10, 2022

Tested using Python 3.10.5 with
snakemake==7.12.0
matplotlib==3.5.2
numpy==1.23.1
graphviz==0.20.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants