Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuleGroup.lastModifiedDate whenever rules are added, updated, or archived #390

Open
3 tasks
ravilodhi opened this issue Dec 13, 2024 · 0 comments
Open
3 tasks
Assignees

Comments

@ravilodhi
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently, every time the ATP rule group executes, it generates a complete CSV containing all eligible products. It does not take into account whether a product has been modified since the last execution or whether the rules have changed since the last run. This results in the CSV being generated with the same data repeatedly, even when there are no changes.

To address this, consider the following approach:

If the rule group has been modified (e.g., new rules are added, existing rules are updated, or archived) since the last successful execution, process all products.
If the rule group has not been modified, only fetch products that have been updated since the last successful rule group execution. Use the updatedDatetime from the Product Solr document for this purpose.

What are the acceptance criteria?

RuleGroup.lastModifiedDate is updating correctly whenever rules are added, updated, or archived.

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

No branches or pull requests

1 participant