Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish a merge/release protocol for this repo #78

Open
espy opened this issue Jul 2, 2015 · 4 comments
Open

Establish a merge/release protocol for this repo #78

espy opened this issue Jul 2, 2015 · 4 comments

Comments

@espy
Copy link
Contributor

espy commented Jul 2, 2015

MFH is the first thing new Hoodie users will see, and we have to be absolutely certain it works correctly. For this reason we'd like to implement two procedures here:

  1. PRs in this repo must be reviewed by two people
  2. This repo needs a merge/release checklist that any committer should work through before submitting a PR (covering testing, dependencies, etc.)
@varjmes
Copy link
Contributor

varjmes commented Jul 2, 2015

This is a great idea. I have seen repositories that have an awesome merge checklist that is added to any new PR that is created, automatically. I am trying to see if I can get access to the core code, so perhaps we can get it added here. If not, perhaps this is something that someone would like to build themselves?

The process is:

  • Person submits a PR
  • Github bot account automatically adds a merge checklist (a markdown file stored in the repository) to the PR
  • Reviewer goes through the checklist and ticks off each item when they're done
  • Reviewer merges

@gr2m
Copy link
Contributor

gr2m commented Jul 2, 2015

sounds great!

@varjmes
Copy link
Contributor

varjmes commented Jul 2, 2015

This is the pull-request bot that some of us use at work. I asked and am told we are free to fork it/use it whatever. Perhaps this is something that hoodie-bot could do for us.

Here is the repo: https://github.com/ms-digital-labs/pull-request-bot

@varjmes
Copy link
Contributor

varjmes commented Jul 3, 2015

If we didn't want to use that one, this is also a thing: https://github.com/btford/mary-poppins, with this plugin: https://github.com/btford/poppins-pr-checklist

boennemann added a commit that referenced this issue Oct 30, 2015
This can now also be published via semantic-release

Closes #79, Closes #78, Closes #77, Closes #61

BREAKING CHANGE: This version can no longer be used as an Hoodie template,
it's just the bare `www` folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants