Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to integrate ipywidgets bokeh into panel #4167

Closed
govinda18 opened this issue Nov 30, 2022 · 1 comment
Closed

Attempt to integrate ipywidgets bokeh into panel #4167

govinda18 opened this issue Nov 30, 2022 · 1 comment
Labels
wontfix This will not be worked on

Comments

@govinda18
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently a lot of logic is same between panel's Ipywidget model and ipywidget bokeh. This requireies any changes made at either of the places to be synced to the other place. A good example is this commit #3915 that ideally needs to be patched to ipywidget_bokeh as well.

Describe the solution you'd like

As discussed yesterday, it may be worth an attempt to move ipywidgets_bokeh into panel instead. This will reduce code duplication and improve maintenance as well.

Describe alternatives you've considered

As of now, I have to manually sync the two to internally make sure that things are in sync between jupyter and standalone dashboard.

Not sure how much effort this is and if this is even feasible. Logging this for starting the discussion.

@philippjfr
Copy link
Member

Thanks for writing this up @govinda18. Thinking about this again there is basically zero chance that we will move the ipywidgets_bokeh model into Panel because including the Jupyter dependencies would increase the Panel.js bundle size by several megabytes. Similarly moving the simplified model that we use in Panel into ipywidgets_bokeh is also not sensible because you will end up loading the ipywidgets_bokeh JS bundle even if it's not necessary (and will lead to issues like this bokeh/ipywidgets_bokeh#65).

Therefore, as annoying as it is, we have to keep both implementations. We can consider porting the change in #3915 to ipywidgets_bokeh or simply wait for the Bokeh 3.0 update which will make layout invalidation entirely unncessary.

@philippjfr philippjfr added the wontfix This will not be worked on label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants