Shifting of painting after complete drawing

[Chris2137]

Hi, it is a follow up on #50

I tried with the latest version 3.0.0-dev.9, the shifting improved a lot. But when the drawing is away from the center, the shifting is obvious, here is what I draw in the picture
original :

draw a red line around the lid :

completed editing :

Open up painting mode again :

Is it going to be fixed? Thanks.

btw, the painting always start after some initial movement, making it hard to start drawing at precise location. Hopefully it can be fixed too. Many thanks.

[hm21]

Thank you for the detailed information. The problem by the image is just by the creation (after you close the painting editor the first time), but after you open/close a subeditor the position is correct, right?
Btw, I add both issues to my to-do list here, so I will give you feedback here after I had time to fix it.

[Chris2137]

Sadly no. To re-iterate the problem,
when I use previous version, 2.7.9,
the situation is : after I edit inside painting editor and close it, it shows correctly on screen; when I open the editor again, it shifts to the left (as discussed in #50). But even if I repeatedly edit the image, it always show correctly on the final image.

In the dev version, 3.0.0-dev
the situation becomes : after I edit inside painting editor and close it, it shows incorrectly on screen (drawing float above the lid); when I open the editor again, it shows same as the 'final image' that the painting is shifted upward. Means I lost my original drawing location. It is shifted upward no matter inside or outside of the editor. Only if my drawing is in the middle of the picture, there will be no shifting happen.

Hope it is clear for you.

[Chris2137]

To supplement, in 2.7.9, I got the correct final image, the only problem is when I open editor again, my drawing is shifted.
In 3.0.0-dev, I can't get correct final image, the drawing is shifted both in final image and when re-open editor (to be fair, the shifting is reduced comparing with previous version)

[hm21]

Okay, I did some tests and we have two options now.

Option 1:

To recalculate the layer position, I can add a function inside the ProImageEditorConfigs that allows you to recalculate the position depending on the size of your main editor. It will look like this:

 configs: ProImageEditorConfigs(
  test: (List<Offset?> offsetPositions, Size paintEditorSize, Size mainEditorSize) {
    List<Offset?> updatedOffsetPositions;

    /// recalculate offset position

    return updatedOffsetPositions;
  }
)

In the real function I will also add stroke width and all stuff because you need next to update all offset positions also to scale down the layer. In my opinion, this will be a bit hard because in “freestyle” mode the layer has a lot of offset positions.

Option 2:

We open the subeditor in the same size and position as the main editor, as you asked me before. The downside here is that any content outside the subeditor will not be interactive. Below I'll post an example where I add a barrierColor that the user can see it's disabled. When the user clicks on this area, the dialog will close and he can interact again.

[Chris2137]

Option 2 would be perfect for my case. The content outside not interactive is perfectly fine in my opinion.
Look forward to the fix. Thanks a lot @hm21

[hm21]

Okay, I added option 2 in the dev branch 3.0.0-dev.12. You can now set it up that way:

ProImageEditor.asset(
      'demo.jpg',
      configs: ProImageEditorConfigs(
            imageEditorTheme: ImageEditorTheme(
                subEditorPage: SubEditorPageTheme(
                    enforceSizeFromMainEditor: true,
                    positionTop: 0,
                    positionLeft: 0,
                    barrierDismissible: true,
                    barrierColor: const Color(0x90272727),
                    borderRadius: BorderRadius.circular(10),
                    transitionsBuilder: (context, animation, secondaryAnimation, child) {
                      return child;
                    }),
             ),
      ),
);

[Chris2137]

Before opening subeditor

After opening subeditor (the subeditor is a bit shifted upwards)
I believe it is because you're respecting the positionTop and positionLeft as absolute position. Any chance that it could respect the safearea settings? Or do you know any way to get offset of safearea ? Thanks.

[Chris2137]

And unfortunately drawing on the final image is not very precise
(draw on the lid)

shifted downward a bit (but observable)