Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Unreadable tables #21

Open
megagrump opened this issue May 27, 2022 · 12 comments
Open

UI: Unreadable tables #21

megagrump opened this issue May 27, 2022 · 12 comments

Comments

@megagrump
Copy link

image

https://en.wikipedia.org/wiki/Amateur_radio_call_signs#Formation_of_an_amateur_radio_call_sign

@hirschan
Copy link
Owner

Thanks, will fix immediately

@megagrump
Copy link
Author

@hirschan
Copy link
Owner

hirschan commented May 28, 2022

Good catch - I have fixed now and will upload later, please let me know if you find more tables. I think it's best to keep this issue open so more tables can be linked here.

The issue with tables is that they have td elements and I cannot override all td elements to dark because that would mess up some other tables, for example this one here would be completely dark: https://es.wikipedia.org/wiki/King_Crimson#Miembros_pasados and also temperature tables with colors would be replaced with dark.

@megagrump megagrump changed the title Unreadable table Unreadable tables May 28, 2022
@megagrump
Copy link
Author

Sure, I'll gladly complain about anything that isn't as perfect as it should be! lol

Thanks for the effort and I commend your taste in music too if you like King Crimson.

@hirschan
Copy link
Owner

It should be fixed now, included in the latest update. Haha actually I don't listen to King Crimson - I just remember some user linking me it when I messed up the table colors ;)

@HanatakeYurii
Copy link

HanatakeYurii commented Jun 29, 2022

I have found something similar, not exactly tables but same problem with half of the text unreadable due to bad contrast:
https://en.wikipedia.org/wiki/Emperor_Monmu
firefox_llrPQ9thhM
https://en.wikipedia.org/wiki/Mineral_(nutrient)
firefox_AaXtGCwdW4

@hirschan
Copy link
Owner

Great, thank you! Will try to fix.

@HanatakeYurii
Copy link

HanatakeYurii commented Jul 1, 2022

Another occurrence in another particular case implying special characters (phonological):
https://en.wikipedia.org/wiki/Affricate
firefox_47FaKQR5Hd
As you can (not) see some characters are black on black thus not showing.
I can see them by highligthing

@hirschan
Copy link
Owner

hirschan commented Jul 2, 2022

Yeah I noticed that too, seems like some changes became overridden. Will look into this soon!

@HanatakeYurii
Copy link

Thanks

@hirschan hirschan changed the title Unreadable tables UI: Unreadable tables Mar 5, 2023
@hirschan
Copy link
Owner

hirschan commented Nov 2, 2023

@Korb
Copy link

Korb commented Jul 10, 2024

Before using the extension:
2024-07-10_20-32-59
After using the extension:
2024-07-10_20-32-35
https://en.wikipedia.org/wiki/XCOM#Released

Dark Mode for Wikipedia 4.5.7 (July 7, 2024)
Mozilla Firefox 129.0b1 (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants