You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this part of hubot-hipchat, you rely on the ability to split on "," but in our case this breaks because HipChat has generated an XMPP JID with a comma in it.
Can you think of any cunning ways to work around this without creating a new channel? Thanks folks!
The text was updated successfully, but these errors were encountered:
Haven't tested this, but this could be a work-around:
Does the JID always include the full room domain? (If not this won't work...)
If you split on .hipchat.com,. To do this, you'd either need a more complicated regex in split, using a lookahead, or to just re-join the domain with the first part of the JID.
If this were merged into the master, we'd probably need to split on HUBOT_HIPCHAT_HOST (or hipchat.com) for robustness...
I'm reasonably sure that comma's are always allowed in JID local parts unless they're at the start (or end if a RTL marker is present) of the label (in which case they violate the directionality rule of the UserNameCaseMapped profile of the PRECIS IdentifierClass, although I think having a number at the start of a JID is disallowed too, but I'm not aware of any implementation that actually follows that rule).
For whatever reason, HipChat generated a room with an XMPP JID of the following form.
In this part of
hubot-hipchat
, you rely on the ability to split on","
but in our case this breaks because HipChat has generated an XMPP JID with a comma in it.Can you think of any cunning ways to work around this without creating a new channel? Thanks folks!
The text was updated successfully, but these errors were encountered: