Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svgs rendering is busted on certain sessions #4853

Open
jay-khatri opened this issue Apr 6, 2023 · 1 comment · May be fixed by #9599 or highlight/rrweb#120
Open

Svgs rendering is busted on certain sessions #4853

jay-khatri opened this issue Apr 6, 2023 · 1 comment · May be fixed by #9599 or highlight/rrweb#120
Labels
bug Something isn't working good first issue Good for newcomers session-replay

Comments

@jay-khatri
Copy link
Collaborator

jay-khatri commented Apr 6, 2023 •
edited
Loading

In certain sessions (which are more likely to be running in localhost), there are svg rendering issues. See a below example by @fwouts to repro the bug.

This may very well be happening in one of our dependent libraries (rrweb for example), and we should confirm whether or not that's the case before jumping in.
@jay-khatri jay-khatri added bug Something isn't working session-replay labels Apr 6, 2023
@jay-khatri jay-khatri added the good first issue Good for newcomers label Apr 6, 2023
@fwouts
Copy link

fwouts commented Apr 6, 2023

Here's an example. What it should look like:
Screenshot 2023-04-06 at 3 42 47 pm

Here's what it looks like:
Screenshot 2023-04-06 at 3 43 02 pm

Reproduction:

@Vadman97 Vadman97 moved this to Todo in Highlight Tasks Apr 25, 2023
This was referenced Nov 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers session-replay
Projects
Highlight Tasks
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed svg rendering issue in rrweb webAbhi/highlight
fixed svg rendering issue webAbhi/rrweb
2 participants
@fwouts @jay-khatri