Support hhvm 4.73 and xhp 4 #9
Conversation
It was a holder for functions and didn't need to be a class. This code was written in a time when autoloading functions was something that the default autoloader (composer) couldn't do. I moved these pseudo contructors the member functions. to_js_value (XHPJS::MapArgument) doesn't look like a public API, so I movesed that to _Private.
|
Sorry for not seeing this sooner; this is a great starting point, but for now I'd rather keep it complete than remove the react support, which is the main purpose for this project. @jjergus, do you agree? |
|
I was only vaguely aware of the existence of this project so don't have much context, but it seems to me that supporting non-React JS projects is still valuable? Obviously it would be best to support both React and recent HHVM versions (xhp-lib 4), but if I only had to pick one I'd probably say support for recent HHVM/xhp-lib 4 is more important (but again, I don't really have much context). |
|
React support was not removed. I merely marked it as deprecated to inform everyone that the current implementation does not work. I created opened #8. |
|
Thanks! |
This PR makes the required changes to pass the typechecker with hhvm 4.73.
I have not updated the outdated React.createElement() javascript.
I have not formatted the code with a modern hackfmt, to keep the diff clear.
We can do a formatting PR later.
refs #6