Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Remove all dict/vec/varray/darray/shape/tuple implicit conversions in assert path #58

Open
fredemmott opened this issue Mar 11, 2021 · 3 comments · May be fixed by #69
Open

Remove all dict/vec/varray/darray/shape/tuple implicit conversions in assert path #58

fredemmott opened this issue Mar 11, 2021 · 3 comments · May be fixed by #69

Comments

@fredemmott
Copy link
Contributor

Related: #48, #18

We're expecting to make darray an alias for dict, varray an alias for vec, and swap the backing store for shapes and tuples to dict/vec respectively in the next 2-8 weeks. Once that has happened in HHVM:

  • this implicit conversion should be removed
  • we should start asserting that a successful assert returns exactly the same value, just with a different type
@fredemmott
Copy link
Contributor Author

  • whenever the HHVM default changes, we should make sure there is a type-assert release that works with it and still has the implicit conversions - then bump the major version and resolve this issue
  • we probably want an intermediate release (or option/global flag) to enable notices when implicit conversions happen

@lexidor
Copy link
Contributor

lexidor commented Sep 27, 2021

We are in a post hadva world. This issue looks very similar to #61.

@lexidor
Copy link
Contributor

lexidor commented Sep 27, 2021

Sorry, that is not quite true. The old array typed specs are still around. The structural types have been modernized already.

@lexidor lexidor linked a pull request May 24, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants