From e819133c35acaee0d45592818d6f950b7e53bffd Mon Sep 17 00:00:00 2001
From: Fred Emmott <fe@fb.com>
Date: Tue, 18 Dec 2018 15:44:54 -0800
Subject: [PATCH] Use server_{input,output} for request input/output in CLI
 mode (#31)

Summary:
`php://input` is never a real file handle, even in CLI mode. We should
change this now we don't need to be PHP-compatible, but for now,
workaround it by exposing the real STDIN.

This demonstrates the diference:

```
<?php
$f = fopen('php://stdin', 'r');
stream_set_blocking($f, false);
fgets($f);
var_dump(feof($f)); // false for php://stdin, true for php://input
```
Pull Request resolved: https://github.com/hhvm/hsl-experimental/pull/31

Reviewed By: kmeht

Differential Revision: D13510875

Pulled By: kmeht

fbshipit-source-id: d0b335f7312a5cdc3dc1a2ce7af112a0be428d1d
---
 src/io/stdio.php | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/src/io/stdio.php b/src/io/stdio.php
index 45faeee8..5943791c 100644
--- a/src/io/stdio.php
+++ b/src/io/stdio.php
@@ -45,7 +45,15 @@ function server_input(): ReadHandle {
  *
  * @see requestOutput
  */
+<<__Memoize>>
 function request_output(): WriteHandle {
+  // php://output has differing eof behavior for interactive stdin - we need
+  // the php://stdout for interactive usage (e.g. repls)
+  /* HH_IGNORE_ERROR[2049] __PHPStdLib */
+  /* HH_IGNORE_ERROR[4107] __PHPStdLib */
+  if (\php_sapi_name() === "cli") {
+    return server_output();
+  }
   return _Private\StdioHandle::requestOutput();
 }
 
@@ -66,6 +74,14 @@ function request_error(): WriteHandle {
  * In CLI mode, this is likely STDIN; for HTTP requests, it may contain the
  * POST data, if any.
  */
+<<__Memoize>>
 function request_input(): ReadHandle {
+  // php://input has differing eof behavior for interactive stdin - we need
+  // the php://stdin for interactive usage (e.g. repls)
+  /* HH_IGNORE_ERROR[2049] __PHPStdLib */
+  /* HH_IGNORE_ERROR[4107] __PHPStdLib */
+  if (\php_sapi_name() === "cli") {
+    return server_input();
+  }
   return _Private\StdioHandle::requestInput();
 }