Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny unknown fields #272

Open
schneems opened this issue Apr 23, 2024 · 3 comments
Open

Deny unknown fields #272

schneems opened this issue Apr 23, 2024 · 3 comments

Comments

@schneems
Copy link
Contributor

Add:

#[serde(deny_unknown_fields)]

To all structs that implement deserialize. For example:

#[derive(Deserialize, Serialize, Debug)]
#[serde(deny_unknown_fields)]
struct PersonV2 {
    name: String,
    updated_at: DateTime<Utc>
}

More info: https://github.com/schneems/magic_migrate/blob/3e43a72c329a2f03c016e0d37cd8ec085af7982f/README.md

@schneems
Copy link
Contributor Author

schneems commented Nov 6, 2024

Either confirm they exist or add them

BrianBorge added a commit to BrianBorge/buildpacks-ruby that referenced this issue Nov 14, 2024
schneems pushed a commit that referenced this issue Nov 15, 2024
@schneems
Copy link
Contributor Author

We are still missing some of the metadata structs

#[derive(Deserialize, Serialize, Debug, Clone)]
pub(crate) struct MetadataV1 {
    pub(crate) version: ResolvedBundlerVersion,
}

@BrianBorge
Copy link
Contributor

Ok I'll add the remaining. Thanks for pointing that out.

BrianBorge added a commit to BrianBorge/buildpacks-ruby that referenced this issue Nov 16, 2024
- There were some structs missed with the first commit to address this issue (93abd77)
schneems added a commit that referenced this issue Dec 13, 2024
- There were some structs missed with the first commit to address this issue (93abd77)

Co-authored-by: Richard Schneeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants