Nullable Request

[endersoncosta]

Maybe we can change the schema validation to add a option in request structure, to inform that the value can be null or undefined and our steps will treat this...

like this:
request: { id: !Number }

or like this:
request: { id: Number || undefined }

[endersoncosta]

Maybe using SUMA to validate these values...

[dalssoft]

By default Suma will not validate null:
https://github.com/herbsjs/suma#null-values

When there is a need for non-nullable, use allowNull: false or presence: true
https://github.com/herbsjs/suma#presence-vs-allownull

How do you think we could bring these feature to Buchu?

[endersoncosta]

I believe that the behavior must be the same, because the Programmer must express your intention to a nullable field... Then presence aways true, but with an option to overide and set as false...

[dalssoft]

regardless of discussion of the default behavior for nullables fields I believe we should have allowNull and presence options working on Buchu

[jhomarolo]

Now that Suma validates Contains and notContains we can improve buchu with these validations as well.

[dalssoft]

@jhomarolo contains requires a value to be validated against, which is not the case. what @endersoncosta is proposing is check for null/empty which allowNull and presence is a better fit

[endersoncosta]

At that moment, buchu accept undefined as a valid value, but reject null...

[dalssoft]

we have two options:
(1) - make the default behavior for null/empty the same across libs
(2) - make request from use case (buchu) have a different behavior

to me entities (gotu) and values (suma) should skip nulls since it is common to have partial data filling, specially for entities

for request it is usually the opposite: you want to make sure all the values are there to start processing the use case unless you explicit inform you want a field to be null/empty

with that I think the next step would leave the current behavior for the libs and improve buchu to refuse null/undefined and be able to use suma's options allowNull and presence on the request definition

[italojs]

this issue is from jun 2020, this still make sense to maintain opened? @endersoncosta

[dalssoft]

we have plent of systems running with Herbs since 2020. how we managed with this problem so far? @endersoncosta @jhomarolo ? workarounds? it is important to understand the patterns we created on top of this limitation

[jhomarolo]

@VictorTBX given that you recently worked on a similar feature, can you tell us if this issue is still valid?

[VictorTBX]

@jhomarolo partially, since we have the new feature for request we can manage which fields I want to receive, but an "allowNull" still may be valid in some scenarios.