Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in _compute_dense_tracks #16

Open
jinlinyi opened this issue Jun 4, 2024 · 1 comment
Open

Bug in _compute_dense_tracks #16

jinlinyi opened this issue Jun 4, 2024 · 1 comment

Comments

@jinlinyi
Copy link

jinlinyi commented Jun 4, 2024

Hi Yuxi,

Thanks for releasing this great project. The depth_predictor and video_depth variables are not used here, which causes error when using _compute_dense_tracks.

tracks_step, visibilities_step, T_First_step = self._compute_sparse_tracks(
video=video,
queries=grid_pts,
backward_tracking=backward_tracking,
wind_length=wind_length,
)

Additional request -- when you push new commits, could you just push without rebase? Otherwise it is hard for me to sync up my code with your latest change. Thank you!

Best,
Linyi

@henry123-boy
Copy link
Owner

Hi Linyi,
Thank you for your kind reminder. I have added the depth_predictor and video_depth there. For rebase, I appologize for that, cause I removed irrelevant history commits before. But the current version is clean already, so I guess you can re-clone and iterate based on the version right now. I am sorry for your inconvenience.

Best,
Yuxi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants