Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor telnetlib #228

Open
hellt opened this issue Jul 9, 2024 · 7 comments · May be fixed by #279
Open

vendor telnetlib #228

hellt opened this issue Jul 9, 2024 · 7 comments · May be fixed by #279

Comments

@hellt
Copy link
Owner

hellt commented Jul 9, 2024

Poor old telnet, we will have to vendor it unless someone swaps the core to using scrapli

ktbyers/netmiko#3444

@kaelemc
Copy link

kaelemc commented Jul 11, 2024

Migration shouldn't be too trivial for the 'core' devices.

I can probably slowly start work on that.

@hellt
Copy link
Owner Author

hellt commented Jul 11, 2024

oh, if you can root out the telnet based wait_writes with scrapli (#164) that would have the biggest long term impact on vrnetlab

@kaelemc
Copy link

kaelemc commented Jul 11, 2024

when is the next release planned?

@hellt
Copy link
Owner Author

hellt commented Jul 11, 2024

there is no release schedule. The releases are cut whenever there is a substantial change merged into master that makes it worth tagging it

@kaelemc
Copy link

kaelemc commented Jul 11, 2024

Should just wait_write be adapted to use scrapli or should we also attempt to use the relevant core drivers that exist?

@kaelemc
Copy link

kaelemc commented Jul 11, 2024

For example, I see a lot Cisco devices are also using telnetlib.expect()

@hellt
Copy link
Owner Author

hellt commented Jul 11, 2024

for others, we will continue syncing about this dev work here https://discord.com/channels/860500297297821756/865526691350839296/1260902111902961745

@kaelemc kaelemc linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants