Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port not set for HomeAssistant notification #513

Open
eloo opened this issue Nov 24, 2023 · 1 comment
Open

Port not set for HomeAssistant notification #513

eloo opened this issue Nov 24, 2023 · 1 comment
Labels
bug Something isn't working confirmed We know what should be done to resolve the issue

Comments

@eloo
Copy link

eloo commented Nov 24, 2023

Description

The configured port of the container is not respected for the homeassistant notification.
This result in a wrong "enable pairing mode" link in the Home Assistant notification.

I guess the issue is that the port is not added to the "ip_address" in this code line:

url = f"http://{self.ip_addr}/link/{self._link_mode_discovery_key}"

Expected behavior

The notification in homeassistant has a link which is also working for non standard ports (currently 80 is "hard-coded")

Reproduction steps

  • Run the container on a different port than 80
  • Click the notification link in Home Assistant
  • See the links going to port 80 and thus not working

Relevant log output

N/A

Operating system

Other

Install method

Docker CLI

Version

0.3.0

Dev Version

No response

Any other information that may be helpful

No response

@eloo eloo added the bug Something isn't working label Nov 24, 2023
@eloo eloo mentioned this issue Jan 14, 2024
Copy link
Contributor

This issue has been marked as stale due to no activity and will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
@alexyao2015 alexyao2015 reopened this Feb 1, 2024
@alexyao2015 alexyao2015 added confirmed We know what should be done to resolve the issue and removed stale labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed We know what should be done to resolve the issue
Projects
None yet
Development

No branches or pull requests

2 participants