Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow imports for workflows service #20776

Open
batuhan-spire opened this issue Dec 23, 2024 · 2 comments
Open

Allow imports for workflows service #20776

batuhan-spire opened this issue Dec 23, 2024 · 2 comments
Labels

Comments

@batuhan-spire
Copy link

Question

Hello,
I was wondering if there is any explanation to not allow imports over workflows. Currently I am unable to use terraform import with workflows because it's not supported.

Error: resource google_workflows_workflow doesn't support import

I am experimenting over a local build of the provider and removing following property just works fine with import command. batuhan-spire/magic-modules@3291ac9

First appearance of the exclude_import keyword over workflows: GoogleCloudPlatform/magic-modules#4308
I don't see any discussions why it would be that way. Maybe it was a default back then?

Thank you

@roaks3
Copy link
Collaborator

roaks3 commented Dec 26, 2024

It appears intentional to not have import (from implementation and the tests), but I wasn't able to find a reason, and it seems like it should be importable. I would definitely give it a try, but don't be surprised if there is something that prevents it from working.

@batuhan-spire
Copy link
Author

I tried a local build of the provider, it seems to fetch the state pretty well after import. Just like it'd pull after create.

I'll try to draft a PR together with tests. So far, it worked for my use case and I was able to import my workflows into terraform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants