Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove archive_file resource deprecated status #367

Merged

Conversation

codymaust
Copy link
Contributor

@codymaust codymaust commented Sep 12, 2024

thank you all for an immensely useful provider

  • from what i gathered from the git history, this resource was
    introduced in v2.3.0 in a deprecated state

  • discussion with the community involving @bendbennett resulted in the
    consideration of this deprecation being removed (see: archive_file data source gets created during "terraform plan" vs "terraform apply" and also is not deleted during destroy #218)

  • since v2.x there has been a strong focus on keeping this provider
    limited to the data source, so some of this proposed change is taking
    a best guess at what makes sense while trying not to depart from the
    overall approach

  • i acknowledge that this appears to be in some ways orthogonal to the
    goal of the project, but there has been little movement in regards to
    this widely-requested feature (understandably so, based on reasons
    mentioned above).

  • there are cases, primarily in a remote build server context, where the
    design decisions/limitations of the data source makes the adoption and
    usage of this provider much more challenging.

this change is proposed as a stop-gap until a larger focus is able to
put on this project by the primary contributing team

fixes #218

@codymaust codymaust requested a review from a team as a code owner September 12, 2024 18:04
Copy link

hashicorp-cla-app bot commented Sep 12, 2024

CLA assistant check
All committers have signed the CLA.

@codymaust codymaust changed the title feat: remove archive_file deprecated status feat: remove archive_file resource deprecated status Sep 12, 2024
@codymaust
Copy link
Contributor Author

i was also unsure how to classify this semantically, but settled on feature because fix seemed even less appropriate

@codymaust codymaust force-pushed the feat/reinstate-archive-file-resource branch from d62db5d to 6a40586 Compare September 24, 2024 13:49
@codymaust
Copy link
Contributor Author

the branch has been updated

- from what i gathered from the git history, this resource was
introduced in `v2.3.0` in a deprecated state

- discussion with the community involving @bendbennett resulted in the
consideration of this deprecation being removed (see: hashicorp#218)

- since `v2.x` there has been a strong focus on keeping this provider
limited to the `data` source, so some of this proposed change is taking
a best guess at what makes sense while trying not to depart from the
overall approach

- i acknowledge that this appears to be in some ways orthogonal to the
goal of the project, but there has been little movement in regards to
this widely-requested feature (understandably so, based on reasons
mentioned above).

- there are cases, primarily in a remote build server context, where the
design decisions/limitations of the `data` source makes the adoption and
usage of this provider much more challenging.

this change is proposed as a stop-gap until a larger focus is able to
put on this project by the primary contributing team
@codymaust codymaust force-pushed the feat/reinstate-archive-file-resource branch from 6a40586 to d2c1b70 Compare November 19, 2024 18:43
Co-authored-by: Selena Goods <[email protected]>
Copy link
Contributor

@SBGoods SBGoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @codymaust! I really appreciate the thoroughness with the documentation changes.

@SBGoods SBGoods merged commit 84ef43b into hashicorp:main Nov 19, 2024
5 checks passed
@SBGoods SBGoods added this to the v2.7.0 milestone Nov 19, 2024
@EAR009
Copy link

EAR009 commented Dec 5, 2024

Hello All, Quick check: Does the version 2.7.0 released?

@SBGoods
Copy link
Contributor

SBGoods commented Dec 5, 2024

Hi @EAR009, I've just cut the 2.7.0 release.

@EAR009
Copy link

EAR009 commented Dec 5, 2024

Hi @EAR009, I've just cut the 2.7.0 release.

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants