Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve legenda for packer's output #13101

Open
EugenKon opened this issue Jul 8, 2024 · 5 comments
Open

Improve legenda for packer's output #13101

EugenKon opened this issue Jul 8, 2024 · 5 comments

Comments

@EugenKon
Copy link

EugenKon commented Jul 8, 2024

Description

image

This is nice to see the description what does this color (1):

amazon-ebs.nomad_ami: output will be in this color.

But there is no description what is this for output in (2), (3) and (4) color.

Use Case(s)

The full legenda for colors will help better.

Expected behaviour

I suppose it should be:

text in greencolor: output will be in this color
text in lightgreencolor: details to the output above will be in this color
text in red: error will be in this color
text in light red: error details will be in this color

etc.

@lbajolet-hashicorp
Copy link
Contributor

Hi @EugenKon,

Regarding the builds, I would suggest adding names to the builds you're running so you can more easily differentiate between which is which, otherwise you won't be able to as you saw.

We could look into adding some information to the prefix for the logs so even in case of conflict it's easier to reconciliate which failed in cases like yours, but I'm fairly confident that meaningful names would be a good resolution to this.

I'll keep it open for revisiting later, maybe we can do something with this, but I'm tempted to not prioritise this if the names do a good enough job to differentiate them.

Thanks!

@EugenKon
Copy link
Author

@lbajolet-hashicorp Sorry, about which names are you speaking about? And how it could be improved?

@lbajolet-hashicorp
Copy link
Contributor

Looking again at your screencap, I was mistaken, you only have one build it seems.
The colours are a bit different because of the method called in this case, not sure why we opted for Message to look different than Say (two different functions from the SDK to print messages to the user), but the darker shade of green are from Message calls, the lighter green are the Says and the red one is from an error.

While the red error colour is expected, the hue difference between the two are a bit more puzzling, I'll inquire internally if there's a reason for this.

@EugenKon
Copy link
Author

I suppose it should be:

text in greencolor: output will be in this color
text in lightgreencolor: details to the output above will be in this color
text in red: error will be in this color
text in light red: error details will be in this color

etc.

I have added this to the main issue.

@tenthirtyam
Copy link
Contributor

The red one can also be the commands sent to an image from a script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants