Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Required Changelog File/Entry Workflow #8

Open
bflad opened this issue May 3, 2021 · 2 comments
Open

Investigate Required Changelog File/Entry Workflow #8

bflad opened this issue May 3, 2021 · 2 comments

Comments

@bflad
Copy link
Contributor

bflad commented May 3, 2021

Description

Certain projects may want an easy GitHub Actions workflow to require changelog entries for pull requests that are managed by go-changelog. Currently, this can be done, but requires some glue scripting, such as what is done by Consul.

It would be great if projects could quickly configure a workflow to enable this behavior. This could be potentially done along with other changelog checks as shown below:

- uses: hashicorp/go-changelog-check
  with:
    pull-request-number: {{ github.event.pull_request.number }}
    required: true
    required-ignore-labels: ["pr/no-changelog"]

References

@paddycarver
Copy link
Contributor

changelog-pr-body-check may be able to serve as the basis for this, too.

@bflad
Copy link
Contributor Author

bflad commented May 24, 2021

For sure! The thinking here is having the actual GitHub Action side of things make this very simple for implementations and the underlying implementation can be whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants