Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change e2e tests to execute cli commands #695

Open
Ivo-Yankov opened this issue Oct 16, 2024 · 0 comments
Open

Change e2e tests to execute cli commands #695

Ivo-Yankov opened this issue Oct 16, 2024 · 0 comments
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team

Comments

@Ivo-Yankov
Copy link
Contributor

Ivo-Yankov commented Oct 16, 2024 •
edited
Loading

Refactor the e2e tests to simulate calling the commands from a terminal.

The current implementation the calls class methods directly and bypasses key functionallity related to the command building.

Utilize child_process.exec or some other alternative to execute solo commands, e.g. solo node add
@Ivo-Yankov Ivo-Yankov added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team labels Oct 16, 2024
@Ivo-Yankov Ivo-Yankov added this to Solo Oct 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team
Projects
Solo
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ivo-Yankov