Support Variable length in non-projective and in alignment

[srush]

Generalize the length argument support for both of these classes.

@kmkurn @tyang92

[kmkurn]

I actually have a working code for variable-length matrix-tree for labeled tree: https://gist.github.com/kmkurn/fb34ad169466b050dddac1de2d1f7b93. This also handles overflow bc of exp when the potentials are extremely positive. I did try to make a PR, but it's not finished yet and I can't say when.

[srush]

Take you time. Would love to have this incorporated whenever you have a chance.

[kmkurn]

Great! For now, I hope my code can help those who need it quickly. Another thing, what can be done easily in the meantime is maybe raise an error/warning if lengths is passed? Because right now it may mislead users thinking variable-length is supported.

[srush]

Will do. El mar., 24 de marzo de 2020 21:09, Kemal Kurniawan < [email protected]> escribió:

…

Great! For now, I hope my code can help those who need it quickly. Another thing, what can be done easily in the meantime is maybe raise an error/warning if lengths is passed? Because right now it may mislead users thinking variable-length is supported. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIYKXTOLFKWJQN67J3RRLRJFKV5ANCNFSM4LSU2WMA> .