-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odb.FieldValue.data
is typed only as tuple
, but should be typed as tuple[float]
#5731
Comments
There is too much work to do about this kind of typing error. |
Hm, I see. 1655 cases are a lot, and many of them are more complicated than this one (with tuples of tuples of enum values). I don't think I'll be able to help with the more complex cases, but I could attempt the simpler ones, and spend some time on that, if that is helpful. But if consistency is a higher priority than having precision in certain places, which I would understand, then I won't be able to assist, given that I won't reach over the whole project. Thoughts? |
Any small fixes are welcome |
|
Describe the bug
A clear and concise description of what the bug is.
In
abqpy/Odb/FieldValue.py:144-152
:The docstrings say that these are tuples of floats, so the typing could reflect this.
Proposed solution is simple:
The text was updated successfully, but these errors were encountered: