Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: DeadCodeEliminationTest.testFloatingPoint() depends on locale setting #10067

Open
jnehlmeier opened this issue Dec 23, 2024 · 0 comments

Comments

@jnehlmeier
Copy link
Member

jnehlmeier commented Dec 23, 2024

Description

DeadCodeEliminationTest.testFloatingPoint() fails if your default locale uses , instead of . in floating point numbers.

I don't like adding -Duser.country=US -Duser.language=en to common.ant.xml -> gwt.junit as I think tests should work without any special configuration, e.g. when running from the IDE directly without ANT.

Instead the test should use String.format(Locale.ENGLISH, ..) when formatting floats to be used as string literals in source code context.

Steps to reproduce

Run ant tests using -Duser.country=DE -Duser.language=de to simulate such a locale setting.

Known workarounds

Run ant tests using -Duser.country=US -Duser.language=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant