diff --git a/app/views/volunteers/_send_reminder_button.html.erb b/app/views/volunteers/_send_reminder_button.html.erb
index e36dfcaeeb..bb309fcbd9 100644
--- a/app/views/volunteers/_send_reminder_button.html.erb
+++ b/app/views/volunteers/_send_reminder_button.html.erb
@@ -1,14 +1,16 @@
-<%= button_tag(
- type: "submit",
- class: "main-btn primary-btn btn-hover btn-sm",
- id: "reminder_button",
- data_toggle: "tooltip",
- title: "Remind volunteer to input case contacts".to_s
-) do %>
-
+ <%= button_tag(
+ type: "submit",
+ class: "main-btn primary-btn btn-hover btn-sm mr-3",
+ id: "reminder_button",
+ data_toggle: "tooltip",
+ title: "Remind volunteer to input case contacts".to_s
+ ) do %>
+
Send Reminder
+ <% end %>
-
diff --git a/lib/tasks/deployment/20240720232939_backfill_case_contact_started_metadata.rake b/lib/tasks/deployment/20240720232939_backfill_case_contact_started_metadata.rake
new file mode 100644
index 0000000000..67e139eadd
--- /dev/null
+++ b/lib/tasks/deployment/20240720232939_backfill_case_contact_started_metadata.rake
@@ -0,0 +1,14 @@
+namespace :after_party do
+ desc "Deployment task: set metadata for status started to every CaseContact that had status metadata"
+ task backfill_case_contact_started_metadata: :environment do
+ puts "Running deploy task 'backfill_case_contact_started_metadata'"
+
+ # Put your task implementation HERE.
+ Deployment::BackfillCaseContactStartedMetadataService.new.backfill_metadata
+
+ # Update task as completed. If you remove the line below, the task will
+ # run with every deploy (or every time you call after_party:run).
+ AfterParty::TaskRecord
+ .create version: AfterParty::TaskRecorder.new(__FILE__).timestamp
+ end
+end
diff --git a/package.json b/package.json
index d516830605..caacb5f833 100644
--- a/package.json
+++ b/package.json
@@ -13,7 +13,7 @@
},
"dependencies": {
"@babel/core": "^7.24.9",
- "@fortawesome/fontawesome-free": "^6.5.2",
+ "@fortawesome/fontawesome-free": "^6.6.0",
"@hotwired/stimulus": "^3.2.2",
"@popperjs/core": "^2.11.8",
"@rails/actioncable": "^7.1.3",
@@ -44,7 +44,7 @@
"strftime": "^0.10.3",
"sweetalert2": "^11.3.5",
"tom-select": "^2.3.1",
- "trix": "^2.1.2",
+ "trix": "^2.1.3",
"turbolinks": "^5.2.0"
},
"version": "0.1.0",
diff --git a/spec/callbacks/case_contact_metadata_callback_spec.rb b/spec/callbacks/case_contact_metadata_callback_spec.rb
new file mode 100644
index 0000000000..a0678dcd63
--- /dev/null
+++ b/spec/callbacks/case_contact_metadata_callback_spec.rb
@@ -0,0 +1,143 @@
+require "rails_helper"
+
+RSpec.describe CaseContactMetadataCallback do
+ let(:past) { Date.new(2020, 1, 1).in_time_zone }
+ let(:parsed_past) { past.as_json }
+
+ let(:present) { Date.new(2024, 1, 1).in_time_zone }
+ let(:parsed_present) { present.as_json }
+
+ before { travel_to present }
+ after { travel_back }
+
+ # NOTE: as you might notice these tests are omitting quite a few cases
+ # ex: notes => details, expenses => notes. I don't think it is worth dealing
+ # with metadata surrounding cases that are not processed in the correct order.
+ # A user would not be able to replicate this behavior.
+ #
+ describe "after_commit" do
+ it "sets started metadata when case contact is created" do
+ cc = create(:case_contact)
+
+ expect(cc.metadata.dig("status", "active")).to eq(parsed_present)
+ end
+
+ context "case contact is in started status" do
+ let(:case_contact) { create(:case_contact, status: "started", created_at: past) }
+
+ context "updates to started status" do
+ before { case_contact.update(status: "started") }
+
+ it "does not update the metadata" do
+ expect(case_contact.metadata.dig("status", "started")).to eq(parsed_past)
+ end
+ end
+
+ context "updates to details status" do
+ before { case_contact.update(status: "details") }
+
+ it { expect(case_contact.metadata.dig("status", "details")).to eq(parsed_present) }
+ end
+
+ context "updates to notes status" do
+ before { case_contact.update(status: "notes") }
+
+ it { expect(case_contact.metadata.dig("status", "notes")).to eq(parsed_present) }
+ end
+
+ context "updates to expenses status" do
+ before { case_contact.update(status: "expenses") }
+
+ it { expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_present) }
+ end
+
+ context "updates to active status" do
+ before { case_contact.update(status: "active") }
+
+ it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
+ end
+ end
+
+ context "case contact is in details status" do
+ let(:case_contact) { create(:case_contact, status: "details", created_at: past) }
+
+ context "updates to details status" do
+ before { case_contact.update(status: "details") }
+
+ it "does not update the metadata" do
+ expect(case_contact.metadata.dig("status", "details")).to eq(parsed_past)
+ end
+ end
+
+ context "updates to notes status" do
+ before { case_contact.update(status: "notes") }
+
+ it { expect(case_contact.metadata.dig("status", "notes")).to eq(parsed_present) }
+ end
+
+ context "updates to expenses status" do
+ before { case_contact.update(status: "expenses") }
+
+ it { expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_present) }
+ end
+
+ context "updates to active status" do
+ before { case_contact.update(status: "active") }
+
+ it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
+ end
+ end
+
+ context "case contact is in notes status" do
+ let(:case_contact) { create(:case_contact, status: "notes", created_at: past) }
+
+ context "updates to notes status" do
+ before { case_contact.update(status: "notes") }
+
+ it { expect(case_contact.metadata.dig("status", "notes")).to eq(parsed_past) }
+ end
+
+ context "updates to expenses status" do
+ before { case_contact.update(status: "expenses") }
+
+ it { expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_present) }
+ end
+
+ context "updates to active status" do
+ before { case_contact.update(status: "active") }
+
+ it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
+ end
+ end
+
+ context "case contact is in expenses status" do
+ let!(:case_contact) { create(:case_contact, status: "expenses", created_at: past) }
+
+ context "updates to expenses status" do
+ before { case_contact.update(status: "expenses") }
+
+ it "does not update the metadata" do
+ expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_past)
+ end
+ end
+
+ context "updates to active status" do
+ before { case_contact.update(status: "active") }
+
+ it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
+ end
+ end
+
+ context "case contact is in active status" do
+ let(:case_contact) { create(:case_contact, created_at: past) }
+
+ context "updates to active status" do
+ before { case_contact.update(status: "active") }
+
+ it "does not update the metadata" do
+ expect(case_contact.metadata.dig("status", "active")).to eq(parsed_past)
+ end
+ end
+ end
+ end
+end
diff --git a/spec/factories/case_contacts.rb b/spec/factories/case_contacts.rb
index 4c2698eb89..35a04e83bd 100644
--- a/spec/factories/case_contacts.rb
+++ b/spec/factories/case_contacts.rb
@@ -59,6 +59,15 @@
trait :expenses_status do
draft_case_ids { [1] }
+ status { "expenses" }
+ end
+
+ after(:create) do |case_contact, evaluator|
+ if evaluator.metadata
+ case_contact.update_columns(metadata: evaluator.metadata)
+ elsif case_contact.status
+ case_contact.update_columns(metadata: {"status" => {case_contact.status => case_contact.created_at}})
+ end
end
trait :with_org_topics do
diff --git a/spec/models/case_contact_spec.rb b/spec/models/case_contact_spec.rb
index 5dd56710d2..f5eabc0ad0 100644
--- a/spec/models/case_contact_spec.rb
+++ b/spec/models/case_contact_spec.rb
@@ -134,10 +134,10 @@
expect(obj.errors.full_messages).to include("Must enter miles driven to receive driving reimbursement.")
end
- it "validates casa case present" do
- obj = build_stubbed(:case_contact, :expenses_status, :wants_reimbursement, casa_case: nil)
+ it "requires a case to be selected" do
+ obj = build_stubbed(:case_contact, :expenses_status, :wants_reimbursement, draft_case_ids: [])
expect(obj).not_to be_valid
- expect(obj.errors.full_messages).to include("Casa case can't be blank")
+ expect(obj.errors.full_messages).to include("You must select at least one casa case.")
end
end
@@ -543,7 +543,7 @@
context "when parameter is not nil" do
it "returns contacts with the given casa case ids" do
- expect(described_class.with_casa_case(casa_case.id)).to eq(case_contacts)
+ expect(described_class.with_casa_case(casa_case.id)).to match_array(case_contacts)
end
end
end
@@ -551,13 +551,13 @@
describe "#contact_groups_with_types" do
it "returns the groups with their associated case types" do
- group1 = build_stubbed(:contact_type_group, name: "Family")
- group2 = build_stubbed(:contact_type_group, name: "Health")
- contact_type1 = build_stubbed(:contact_type, contact_type_group: group1, name: "Parent")
- contact_type2 = build_stubbed(:contact_type, contact_type_group: group2, name: "Medical Professional")
- contact_type3 = build_stubbed(:contact_type, contact_type_group: group2, name: "Other Therapist")
+ group1 = build(:contact_type_group, name: "Family")
+ group2 = build(:contact_type_group, name: "Health")
+ contact_type1 = build(:contact_type, contact_type_group: group1, name: "Parent")
+ contact_type2 = build(:contact_type, contact_type_group: group2, name: "Medical Professional")
+ contact_type3 = build(:contact_type, contact_type_group: group2, name: "Other Therapist")
case_contact_types = [contact_type1, contact_type2, contact_type3]
- case_contact = build_stubbed(:case_contact)
+ case_contact = create(:case_contact)
case_contact.contact_types = case_contact_types
groups_with_types = case_contact.contact_groups_with_types
diff --git a/spec/requests/all_casa_admins/casa_admins_spec.rb b/spec/requests/all_casa_admins/casa_admins_spec.rb
index 3f570af5db..1d91b46f35 100644
--- a/spec/requests/all_casa_admins/casa_admins_spec.rb
+++ b/spec/requests/all_casa_admins/casa_admins_spec.rb
@@ -39,7 +39,7 @@
it "renders new page" do
expect { subject }.not_to change(CasaAdmin, :count)
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response).to render_template "casa_admins/new"
end
end
@@ -92,7 +92,7 @@
it "renders new page" do
subject
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response).to render_template "casa_admins/edit"
end
end
@@ -130,7 +130,7 @@
it "renders edit page" do
subject
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response).to render_template "casa_admins/edit"
end
end
@@ -168,7 +168,7 @@
it "renders edit page" do
subject
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response).to render_template "casa_admins/edit"
end
end
diff --git a/spec/requests/all_casa_admins_spec.rb b/spec/requests/all_casa_admins_spec.rb
index d2896f55fc..37fe7e9e5d 100644
--- a/spec/requests/all_casa_admins_spec.rb
+++ b/spec/requests/all_casa_admins_spec.rb
@@ -91,7 +91,7 @@
email: ""
}
}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response).to render_template "all_casa_admins/new"
end
@@ -132,7 +132,7 @@
it "does not update the all_casa_admin" do
other_admin = create(:all_casa_admin)
patch all_casa_admins_path, params: {all_casa_admin: {email: other_admin.email}}
- expect(response).to have_http_status(:ok)
+ expect(response).to have_http_status(:unprocessable_entity)
expect(admin.email).to_not eq "newemail@example.com"
end
@@ -201,7 +201,7 @@
it "does not update the all_casa_admin password" do
subject
- expect(response).to have_http_status(:ok)
+ expect(response).to have_http_status(:unprocessable_entity)
expect(admin.reload.valid_password?("newpassword")).to be false
end
diff --git a/spec/requests/casa_cases_spec.rb b/spec/requests/casa_cases_spec.rb
index 3008265605..98ea95562e 100644
--- a/spec/requests/casa_cases_spec.rb
+++ b/spec/requests/casa_cases_spec.rb
@@ -231,9 +231,9 @@
).by(0)
end
- it "renders a successful response (i.e. to display the 'new' template)" do
+ it "renders an unprocessable entity response (i.e. to display the 'new' template)" do
post casa_cases_url, params: {casa_case: invalid_attributes}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
end
it "also respond to json", :aggregate_failures do
@@ -271,9 +271,9 @@
)
end
- it "renders a successful response (i.e. to display the 'new' template)" do
+ it "renders an unprocessable entity response (i.e. to display the 'new' template)" do
post casa_cases_url, params: {casa_case: invalid_params}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
end
end
end
@@ -329,9 +329,9 @@
end
context "with invalid parameters" do
- it "renders a successful response displaying the edit template" do
+ it "renders an unprocessable entity response displaying the edit template" do
patch casa_case_url(casa_case), params: {casa_case: invalid_attributes}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
end
it "also responds as json", :aggregate_failures do
diff --git a/spec/requests/casa_org_spec.rb b/spec/requests/casa_org_spec.rb
index 227c17ebd9..cc358ddef3 100644
--- a/spec/requests/casa_org_spec.rb
+++ b/spec/requests/casa_org_spec.rb
@@ -113,7 +113,7 @@
end
context "and html format" do
- it { is_expected.to be_successful }
+ it { is_expected.to have_http_status(:unprocessable_entity) }
it "renders the edit template" do
expect(request.body).to match(/error_explanation/)
diff --git a/spec/requests/court_dates_spec.rb b/spec/requests/court_dates_spec.rb
index 1011db18d9..ddec9c15ce 100644
--- a/spec/requests/court_dates_spec.rb
+++ b/spec/requests/court_dates_spec.rb
@@ -260,9 +260,9 @@
end.to change(CourtDate, :count).by(0)
end
- it "renders a successful response (i.e. to display the 'new' template)" do
+ it "renders an unprocessable entity response (i.e. to display the 'new' template)" do
post casa_case_court_dates_path(casa_case), params: {court_date: invalid_attributes}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expected_errors = [
"Date can't be blank",
"Date is not valid. Court date must be within one year from today.",
@@ -305,10 +305,10 @@
end
context "with invalid parameters" do
- it "renders a successful response displaying the edit template" do
+ it "renders an unprocessable entity response displaying the edit template" do
patch casa_case_court_date_path(casa_case, court_date), params: {court_date: invalid_attributes}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
expected_errors = [
"Date can't be blank",
"Date is not valid. Court date must be within one year from today.",
diff --git a/spec/requests/fund_requests_spec.rb b/spec/requests/fund_requests_spec.rb
index 95f3f28c93..343603d0bc 100644
--- a/spec/requests/fund_requests_spec.rb
+++ b/spec/requests/fund_requests_spec.rb
@@ -147,7 +147,7 @@
end
end
- context "with in valid params" do
+ context "with invalid params" do
it "does not create fund request or call mailer" do
volunteer = create(:volunteer, :with_casa_cases)
casa_case = volunteer.casa_cases.first
@@ -170,7 +170,7 @@
}
}.to_not change(FundRequest, :count)
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
end
end
end
diff --git a/spec/requests/mileage_rates_spec.rb b/spec/requests/mileage_rates_spec.rb
index d76acf9290..956120aade 100644
--- a/spec/requests/mileage_rates_spec.rb
+++ b/spec/requests/mileage_rates_spec.rb
@@ -80,7 +80,7 @@
expect {
post mileage_rates_path, params: params
}.to_not change { MileageRate.count }
- expect(response).to have_http_status(:success)
+ expect(response).to have_http_status(:unprocessable_entity)
end
end
@@ -104,7 +104,7 @@
expect {
post mileage_rates_path, params: params
}.to_not change { MileageRate.count }
- expect(response).to have_http_status(:success)
+ expect(response).to have_http_status(:unprocessable_entity)
end
end
end
@@ -140,7 +140,7 @@
it "does not update a mileage rate" do
patch mileage_rate_path(mileage_rate), params: params
- expect(response).to have_http_status(:success)
+ expect(response).to have_http_status(:unprocessable_entity)
mileage_rate.reload
expect(mileage_rate.amount).to eq(10.11)
diff --git a/spec/requests/supervisors_spec.rb b/spec/requests/supervisors_spec.rb
index b605193812..350e24d5fc 100644
--- a/spec/requests/supervisors_spec.rb
+++ b/spec/requests/supervisors_spec.rb
@@ -177,7 +177,7 @@
it "gracefully fails" do
patch supervisor_path(supervisor), params: {supervisor: {email: other_supervisor.email}}
- expect(response).to be_successful
+ expect(response).to have_http_status(:unprocessable_entity)
end
end
end
diff --git a/spec/requests/users_spec.rb b/spec/requests/users_spec.rb
index a00288dab2..d362f8f705 100644
--- a/spec/requests/users_spec.rb
+++ b/spec/requests/users_spec.rb
@@ -426,7 +426,7 @@
patch add_language_users_path(volunteer), params: {
language_id: ""
}
- expect(response).to have_http_status(200)
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response.body).to include("Please select a language before adding.")
end
end
@@ -449,7 +449,7 @@
end
it "should notify the user that the language is already in their list" do
- expect(response).to have_http_status(200)
+ expect(response).to have_http_status(:unprocessable_entity)
expect(response.body).to include("#{language.name} is already in your languages list.")
end
end
diff --git a/spec/requests/volunteers_spec.rb b/spec/requests/volunteers_spec.rb
index 59159e68d3..88f4a1321f 100644
--- a/spec/requests/volunteers_spec.rb
+++ b/spec/requests/volunteers_spec.rb
@@ -218,7 +218,7 @@
post volunteers_url, params: params
}.to change(Volunteer, :count).by(0)
.and change(ActionMailer::Base.deliveries, :count).by(0)
- expect(response).to have_http_status(:success)
+ expect(response).to have_http_status(:unprocessable_entity)
end
end
end
@@ -262,7 +262,7 @@
patch volunteer_path(volunteer), params: {
volunteer: {email: other_volunteer.email, display_name: "New Name", phone_number: "+15463457898"}
}
- expect(response).to have_http_status(:success) # Re-renders form
+ expect(response).to have_http_status(:unprocessable_entity)
volunteer.reload
expect(volunteer.display_name).to_not eq "New Name"
diff --git a/spec/services/case_contact_update_service_spec.rb b/spec/services/case_contact_update_service_spec.rb
deleted file mode 100644
index b49b25a438..0000000000
--- a/spec/services/case_contact_update_service_spec.rb
+++ /dev/null
@@ -1,203 +0,0 @@
-require "rails_helper"
-
-RSpec.describe CaseContactUpdateService do
- let(:updater) { described_class.new(case_contact) }
- let(:case_contact) { create(:case_contact) }
-
- let!(:now) { Time.zone.now }
- let!(:one_day_ago) { 1.day.ago }
- let!(:two_days_ago) { 2.days.ago }
-
- before { travel_to one_day_ago }
- after { travel_back }
-
- describe "#update_attributes" do
- context "case is in details status" do
- let!(:case_contact) { create(:case_contact, status: "details", created_at: two_days_ago) }
-
- context "status is not updated" do
- before { updater.update_attrs({notes: "stuff"}) }
-
- it { expect(case_contact.metadata).to eq({}) }
- it { expect(updater.update_attrs({notes: "stuff"})).to be true }
- end
-
- it "does not update metadata if attrs are invalid" do
- result = updater.update_attrs({occurred_at: 50.years.ago})
- expect(case_contact.metadata).to eq({})
- expect(result).to be false
- end
-
- context "gets updated to details" do
- before { updater.update_attrs({status: "details"}) }
-
- it "updates details metadata to current date" do
- date = case_contact.metadata.dig("status", "details")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("details") }
- end
-
- context "gets updated to expenses" do
- before { updater.update_attrs({status: "expenses"}) }
-
- it "updates expenses metadata to current date" do
- date = case_contact.metadata.dig("status", "expenses")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("expenses") }
- end
-
- context "gets updated to active" do
- before { updater.update_attrs({status: "active"}) }
-
- it "updates active metadata to current date" do
- date = case_contact.metadata.dig("status", "active")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("active") }
- end
- end
-
- context "case is in expenses status" do
- let!(:case_contact) { create(:case_contact, status: "expenses", created_at: two_days_ago) }
-
- context "status is not updated" do
- before { updater.update_attrs({notes: "stuff"}) }
-
- it { expect(case_contact.metadata).to eq({}) }
- it { expect(updater.update_attrs({notes: "stuff"})).to be true }
- end
-
- it "does not update metadata if attrs are invalid" do
- result = updater.update_attrs({occurred_at: 50.years.ago})
- expect(case_contact.metadata).to eq({})
- expect(result).to be false
- end
-
- context "gets updated to details" do
- before { updater.update_attrs({status: "details"}) }
-
- it "updates details metadata to current date" do
- date = case_contact.metadata.dig("status", "details")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("details") }
- end
-
- context "gets updated to expenses" do
- before { updater.update_attrs({status: "expenses"}) }
-
- it "updates expenses metadata to current date" do
- date = case_contact.metadata.dig("status", "expenses")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("expenses") }
- end
-
- context "gets updated to active" do
- before { updater.update_attrs({status: "active"}) }
-
- it "updates active metadata to current date" do
- date = case_contact.metadata.dig("status", "active")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("active") }
- end
- end
-
- context "case is in active status" do
- let!(:case_contact) { create(:case_contact, status: "active", created_at: two_days_ago) }
-
- context "status is not updated" do
- before { updater.update_attrs({notes: "stuff"}) }
-
- it { expect(case_contact.metadata).to eq({}) }
- it { expect(updater.update_attrs({notes: "stuff"})).to be true }
- end
-
- it "does not update metadata if attrs are invalid" do
- result = updater.update_attrs({occurred_at: 50.years.ago})
- expect(case_contact.metadata).to eq({})
- expect(result).to be false
- end
-
- context "gets updated to details" do
- before { updater.update_attrs({status: "details"}) }
-
- it "updates details metadata to current date" do
- date = case_contact.metadata.dig("status", "details")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("details") }
- end
-
- context "gets updated to expenses" do
- before { updater.update_attrs({status: "expenses"}) }
-
- it "updates expenses metadata to current date" do
- date = case_contact.metadata.dig("status", "expenses")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("expenses") }
- end
-
- context "gets updated to active" do
- before { updater.update_attrs({status: "active"}) }
-
- it "updates active metadata to current date" do
- date = case_contact.metadata.dig("status", "active")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("active") }
- end
- end
-
- context "case is in started status" do
- let!(:case_contact) { create(:case_contact, status: "started", created_at: two_days_ago) }
-
- context "status is not updated" do
- before { updater.update_attrs({notes: "stuff"}) }
-
- it { expect(case_contact.metadata).to eq({}) }
- it { expect(updater.update_attrs({notes: "stuff"})).to be true }
- end
-
- it "does not update metadata if attrs are invalid" do
- result = updater.update_attrs({occurred_at: 50.years.ago})
- expect(case_contact.metadata).to eq({})
- expect(result).to be false
- end
-
- context "gets updated to details" do
- before { updater.update_attrs({status: "details"}) }
-
- it "updates details metadata to current date" do
- date = case_contact.metadata.dig("status", "details")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("details") }
- end
-
- context "gets updated to expenses" do
- before { updater.update_attrs({status: "expenses"}) }
-
- it "updates expenses metadata to current date" do
- date = case_contact.metadata.dig("status", "expenses")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("expenses") }
- end
-
- context "gets updated to active" do
- before { updater.update_attrs({status: "active"}) }
-
- it "updates active metadata to current date" do
- date = case_contact.metadata.dig("status", "active")
- expect(DateTime.parse(date)).to eq(Time.zone.now)
- end
- it { expect(case_contact.status).to eq("active") }
- end
- end
- end
-end
diff --git a/spec/services/deployment/backfill_case_contact_started_metadata_service_spec.rb b/spec/services/deployment/backfill_case_contact_started_metadata_service_spec.rb
new file mode 100644
index 0000000000..0ff4fe8329
--- /dev/null
+++ b/spec/services/deployment/backfill_case_contact_started_metadata_service_spec.rb
@@ -0,0 +1,55 @@
+require "rails_helper"
+
+RSpec.describe Deployment::BackfillCaseContactStartedMetadataService do
+ let(:past) { Date.new(2020, 1, 1).in_time_zone }
+ let(:parsed_past) { past.as_json }
+
+ let(:present) { Date.new(2024, 1, 1).in_time_zone }
+ let(:parsed_present) { present.as_json }
+
+ before { travel_to present }
+ after { travel_back }
+
+ context "when a case contact has status metadata" do
+ let(:case_contact) { create(:case_contact) }
+
+ context "when a case contact has status started metadata" do
+ let!(:case_contact) { create(:case_contact, created_at: past, status: "started") }
+
+ it "does not change metadata" do
+ described_class.new.backfill_metadata
+
+ expect(case_contact.reload.metadata.dig("status", "started")).to eq(parsed_past)
+ end
+ end
+
+ context "when a case contact has other status metadata" do
+ let!(:case_contact) {
+ create(:case_contact, created_at: past, metadata:
+ {"status" => {"details" => parsed_past}})
+ }
+
+ it "does not change status details" do
+ described_class.new.backfill_metadata
+
+ expect(case_contact.reload.metadata.dig("status", "started")).to eq(parsed_past)
+ end
+
+ it "sets status started" do
+ described_class.new.backfill_metadata
+
+ expect(case_contact.reload.metadata.dig("status", "started")).to eq(parsed_past)
+ end
+ end
+ end
+
+ context "when a case contact has no metadata" do
+ let!(:case_contact) { create(:case_contact, created_at: past, metadata: {}) }
+
+ it "does not change metadata" do
+ described_class.new.backfill_metadata
+
+ expect(case_contact.reload.metadata.dig("status", "started")).to be_nil
+ end
+ end
+end
diff --git a/spec/support/flipper_helper.rb b/spec/support/flipper_helper.rb
new file mode 100644
index 0000000000..8c57d04ea4
--- /dev/null
+++ b/spec/support/flipper_helper.rb
@@ -0,0 +1,5 @@
+RSpec.configure do |config|
+ config.before(:each, :flipper) do
+ allow(Flipper).to receive(:enabled?)
+ end
+end
diff --git a/spec/system/case_contacts/additional_expenses_spec.rb b/spec/system/case_contacts/additional_expenses_spec.rb
index 6f5e3a8da8..ee06171cf6 100644
--- a/spec/system/case_contacts/additional_expenses_spec.rb
+++ b/spec/system/case_contacts/additional_expenses_spec.rb
@@ -1,7 +1,7 @@
require "rails_helper"
require "action_view"
-RSpec.describe "additional_expenses", type: :system do
+RSpec.describe "additional_expenses", type: :system, flipper: true do
let(:organization) { build(:casa_org, additional_expenses_enabled: true) }
let(:volunteer) { create(:volunteer, casa_org: organization) }
let(:casa_case) { create(:casa_case, casa_org: organization) }
@@ -11,12 +11,14 @@
create(:case_assignment, casa_case: casa_case, volunteer: volunteer)
end
- it "can be set per organization", js: true do
+ it "additional expenses and notices can be set per organization", js: true do
other_organization = build(:casa_org)
other_volunteer = create(:volunteer, casa_org: other_organization)
other_casa_case = create(:casa_case, casa_org: other_organization)
create(:case_assignment, casa_case: other_casa_case, volunteer: other_volunteer)
+ allow(Flipper).to receive(:enabled?).with(:reimbursement_warning, organization).and_return(true)
+
sign_in volunteer
visit casa_case_path(casa_case.id)
click_on "New Case Contact"
@@ -25,6 +27,7 @@
complete_notes_page
expect(page).to have_text("Other Expenses")
+ expect(page).to have_text("Volunteers are eligible to be reimbursed for case-related travel")
sign_in other_volunteer
visit casa_case_path(other_casa_case.id)
@@ -34,6 +37,7 @@
complete_notes_page
expect(page).not_to have_text("Other Expenses")
+ expect(page).not_to have_text("Volunteers are eligible to be reimbursed for case-related travel")
end
context "when setting additional expenses" do
diff --git a/spec/system/case_contacts/new_spec.rb b/spec/system/case_contacts/new_spec.rb
index ac700d7128..e425f9876e 100644
--- a/spec/system/case_contacts/new_spec.rb
+++ b/spec/system/case_contacts/new_spec.rb
@@ -1,7 +1,7 @@
require "rails_helper"
require "action_view"
-RSpec.describe "case_contacts/new", type: :system, js: true do
+RSpec.describe "case_contacts/new", type: :system, js: true, flipper: true do
include ActionView::Helpers::SanitizeHelper
context "when admin" do
diff --git a/yarn.lock b/yarn.lock
index ad0aaeec84..ece1da990d 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -23,11 +23,6 @@
resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.24.9.tgz#53eee4e68f1c1d0282aa0eb05ddb02d033fc43a0"
integrity sha512-e701mcfApCJqMMueQI0Fb68Amflj83+dvAvHawoBpAz+GDjCIyGHzNwnefjsWJ3xiYAqqiQFoWbspGYBdb2/ng==
-"@babel/compat-data@^7.24.8":
- version "7.24.9"
- resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.24.9.tgz#53eee4e68f1c1d0282aa0eb05ddb02d033fc43a0"
- integrity sha512-e701mcfApCJqMMueQI0Fb68Amflj83+dvAvHawoBpAz+GDjCIyGHzNwnefjsWJ3xiYAqqiQFoWbspGYBdb2/ng==
-
"@babel/core@^7.11.6", "@babel/core@^7.12.3", "@babel/core@^7.24.9":
version "7.24.9"
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.24.9.tgz#dc07c9d307162c97fa9484ea997ade65841c7c82"
@@ -173,18 +168,7 @@
"@babel/traverse" "^7.24.7"
"@babel/types" "^7.24.7"
-"@babel/helper-module-transforms@^7.24.7", "@babel/helper-module-transforms@^7.24.9":
- version "7.24.9"
- resolved "https://registry.yarnpkg.com/@babel/helper-module-transforms/-/helper-module-transforms-7.24.9.tgz#e13d26306b89eea569180868e652e7f514de9d29"
- integrity sha512-oYbh+rtFKj/HwBQkFlUzvcybzklmVdVV3UU+mN7n2t/q3yGHbuVdNxyFvSBO1tfvjyArpHNcWMAzsSPdyI46hw==
- dependencies:
- "@babel/helper-environment-visitor" "^7.24.7"
- "@babel/helper-module-imports" "^7.24.7"
- "@babel/helper-simple-access" "^7.24.7"
- "@babel/helper-split-export-declaration" "^7.24.7"
- "@babel/helper-validator-identifier" "^7.24.7"
-
-"@babel/helper-module-transforms@^7.24.8":
+"@babel/helper-module-transforms@^7.24.7", "@babel/helper-module-transforms@^7.24.8", "@babel/helper-module-transforms@^7.24.9":
version "7.24.9"
resolved "https://registry.yarnpkg.com/@babel/helper-module-transforms/-/helper-module-transforms-7.24.9.tgz#e13d26306b89eea569180868e652e7f514de9d29"
integrity sha512-oYbh+rtFKj/HwBQkFlUzvcybzklmVdVV3UU+mN7n2t/q3yGHbuVdNxyFvSBO1tfvjyArpHNcWMAzsSPdyI46hw==
@@ -263,11 +247,6 @@
resolved "https://registry.yarnpkg.com/@babel/helper-validator-option/-/helper-validator-option-7.24.8.tgz#3725cdeea8b480e86d34df15304806a06975e33d"
integrity sha512-xb8t9tD1MHLungh/AIoWYN+gVHaB9kwlu8gffXGSt3FFEIT7RjS+xWbc2vUD1UTZdIpKj/ab3rdqJ7ufngyi2Q==
-"@babel/helper-validator-option@^7.24.8":
- version "7.24.8"
- resolved "https://registry.yarnpkg.com/@babel/helper-validator-option/-/helper-validator-option-7.24.8.tgz#3725cdeea8b480e86d34df15304806a06975e33d"
- integrity sha512-xb8t9tD1MHLungh/AIoWYN+gVHaB9kwlu8gffXGSt3FFEIT7RjS+xWbc2vUD1UTZdIpKj/ab3rdqJ7ufngyi2Q==
-
"@babel/helper-wrap-function@^7.24.7":
version "7.24.7"
resolved "https://registry.yarnpkg.com/@babel/helper-wrap-function/-/helper-wrap-function-7.24.7.tgz#52d893af7e42edca7c6d2c6764549826336aae1f"
@@ -1167,10 +1146,10 @@
resolved "https://registry.yarnpkg.com/@eslint/js/-/js-8.43.0.tgz#559ca3d9ddbd6bf907ad524320a0d14b85586af0"
integrity sha512-s2UHCoiXfxMvmfzqoN+vrQ84ahUSYde9qNO1MdxmoEhyHWsfmwOpFlwYV+ePJEVc7gFnATGUi376WowX1N7tFg==
-"@fortawesome/fontawesome-free@^6.5.2":
- version "6.5.2"
- resolved "https://registry.yarnpkg.com/@fortawesome/fontawesome-free/-/fontawesome-free-6.5.2.tgz#310fe90cb5a8dee9698833171b98e7835404293d"
- integrity sha512-hRILoInAx8GNT5IMkrtIt9blOdrqHOnPBH+k70aWUAqPZPgopb9G5EQJFpaBx/S8zp2fC+mPW349Bziuk1o28Q==
+"@fortawesome/fontawesome-free@^6.6.0":
+ version "6.6.0"
+ resolved "https://registry.yarnpkg.com/@fortawesome/fontawesome-free/-/fontawesome-free-6.6.0.tgz#0e984f0f2344ee513c185d87d77defac4c0c8224"
+ integrity sha512-60G28ke/sXdtS9KZCpZSHHkCbdsOGEhIUGlwq6yhY74UpTiToIh8np7A8yphhM4BWsvNFtIvLpi4co+h9Mr9Ow==
"@hapi/hoek@^9.0.0":
version "9.3.0"
@@ -5428,10 +5407,10 @@ tr46@^3.0.0:
dependencies:
punycode "^2.1.1"
-trix@^2.1.2:
- version "2.1.2"
- resolved "https://registry.yarnpkg.com/trix/-/trix-2.1.2.tgz#8185fa7e12d6cbee93db7f149907b3f7a79b3704"
- integrity sha512-PsQC4qn1Ub0djn7FZ9KLzEC2whE1J27JiRycn5WddlVT8JgwKq5PtlXo6rRfjc7Qj2aSzIdjkApai9zAW7/IRA==
+trix@^2.1.3:
+ version "2.1.3"
+ resolved "https://registry.yarnpkg.com/trix/-/trix-2.1.3.tgz#38c8725cd1864ca5e9784aed7d043fa11669ba81"
+ integrity sha512-LqMp67LiKMQytAHKqNL1Jgmfz69ViW+WBOQTPA2BlMIuxic1mw5vHgDtOE0bvvojUdjAxh0EJtLpJn6BC/2JKw==
tsconfig-paths@^3.14.1:
version "3.14.1"