Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HexEditor right side editing is broken #3777

Closed
tig opened this issue Oct 6, 2024 · 1 comment · Fixed by #3783
Closed

HexEditor right side editing is broken #3777

tig opened this issue Oct 6, 2024 · 1 comment · Fixed by #3783
Labels
bug
Milestone
V2 Beta

Comments

@tig
Copy link
Collaborator

tig commented Oct 6, 2024

Somewhere along the way, the ability to type on the right side of HexEditor broke.

Also:

  • Needs Code Cleanup.
  • Enter should not switch sides, but Tab and Shift+Tab should (and navigate out).
  • Enter should accept.
  • Needs Better unit tests.
@tig tig added the bug label Oct 6, 2024
@tig tig added this to the V2 Beta milestone Oct 6, 2024
@tig tig mentioned this issue Oct 8, 2024
Merged
11 tasks
@BDisp
Copy link
Collaborator

BDisp commented Oct 8, 2024 •
edited
Loading

Based on this comment #3766 (comment).

Only to remember that the navigation have to be fixed in Navigation API and not in the HexEditor.

@tig tig mentioned this issue Oct 9, 2024
Merged
14 tasks
@tig tig closed this as completed in #3783 Oct 15, 2024
tig added a commit that referenced this issue Oct 15, 2024
@tig
Merge pull request #3783 from tig/v2_3777-hexedit
d6a652b 
Fixes #3777 - `HexView` Focus Issue - Adds `View.AdvancingFocus` events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Terminal.Gui V2 Initial Release
Status: ✅ Done
Milestone
V2 Beta
Development

Successfully merging a pull request may close this issue.

Fixes #3777 - HexView Focus Issue - Adds View.AdvancingFocus events tig/Terminal.Gui
2 participants
@tig @BDisp