Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon style overrides from Button component #1514

Open
jamesmockett opened this issue Jun 5, 2024 · 0 comments
Open

Remove icon style overrides from Button component #1514

jamesmockett opened this issue Jun 5, 2024 · 0 comments
Assignees

Comments

@jamesmockett
Copy link
Contributor

jamesmockett commented Jun 5, 2024

The button component overrides icon styles in order to set colour and size. These can be both be achieved without the need for overrides with the icon's theme and size props. The overrides should be removed in favour of using these props in order to make the styling more consistent and predictable.

This should be done after #1476 has been merged.

@jamesmockett jamesmockett self-assigned this Jun 5, 2024
@jamesmockett jamesmockett linked a pull request Jun 13, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant