Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cypress dependency from CSNX #1490

Open
SiAdcock opened this issue May 24, 2024 · 0 comments
Open

Remove Cypress dependency from CSNX #1490

SiAdcock opened this issue May 24, 2024 · 0 comments
Assignees

Comments

@SiAdcock
Copy link
Contributor

SiAdcock commented May 24, 2024

What

These tests are the only Cypress tests in CSNX. We should convert them to Playwright.

Why

  • fixes compatibility issue concerning Jest and Cypress tests. Currently we're working around this with --skipLibCheck, but this is not good practice
  • eventually we will move this code to DCR, which uses Playwright. We only need one E2E testing framework, and Playwright is better

Can we delete the tests?

T&C are keen to keep these tests. From @vlkerag:

I think it is worth keeping them. They are essentially running a local version of the canaries to check that things are still working on that particular PR

@SiAdcock SiAdcock changed the title Remove cypress dependency from CSNX Remove Cypress dependency from CSNX May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants