Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final PubSub Messages not reaching SimpleCollisionsMetrics Plugin #506

Open
christomaszewski opened this issue Jan 4, 2021 · 0 comments

Comments

@christomaszewski
Copy link
Contributor

It doesn't seem like the final messages being sent in the SimControl::finalize() function (namely the EntityPresentAtEnd messages) actually reach the SimpleCollisionMetrics plugin because run_network and run_metrics() are not called after publishing these messages. This causes incorrect output from the metrics plugin concerning whether an entity survived or not.

Furthermore, it seems as though some additional messages are getting hung up somewhere because after fixing this issue, the results presented by the SimpleCollisionsMetrics plugin (e.g. total flight time) seem to change (and look more accurate?). This can be seen when running the straight mission and looking at the metrics for the team with a single agent when that agent survives the entire mission; although the entire one agent team survives the whole simulation (100s) the total flight time is reported as substantially less (reported as 53 for me).

Suggested a fix to this in PR #504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant