From be2ef2e589e4969c84dd5e317be8344a85926237 Mon Sep 17 00:00:00 2001 From: Abhishek Ranjan <159750762+aranjans@users.noreply.github.com> Date: Tue, 25 Jun 2024 16:23:58 +0530 Subject: [PATCH 1/3] Cleanup --- L9-go-resolver-balancer-API.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/L9-go-resolver-balancer-API.md b/L9-go-resolver-balancer-API.md index 7bb0cb37e..af101792b 100644 --- a/L9-go-resolver-balancer-API.md +++ b/L9-go-resolver-balancer-API.md @@ -53,7 +53,7 @@ gRPC first gets an address picked by the balancer. Balancer picks the address ba #### The balancing policy needs to be changed on service config updates -Upon service config updating, gRPC will look at the LoadBalancingPolicy field and decide which balancing policy to use. If the LoadBalancingPolicy specified by the service config is different from what's currently being used, gRPC should be able to change the policy. Refer to go/grpc-service-config for more details on this. +Upon service config updating, gRPC will look at the LoadBalancingPolicy field and decide which balancing policy to use. If the LoadBalancingPolicy specified by the service config is different from what's currently being used, gRPC should be able to change the policy. Right now, there's no API to notify balancer of service config changes, so to change the balancing policy, the balancer needs to be swapped out. But swapping out the balancer and at the same time keeping the old resolver and address pool is not feasible because of the v1 structure. From b76f8183442142935e304ce8a6f13c69dba1a0b7 Mon Sep 17 00:00:00 2001 From: Abhishek Ranjan <159750762+aranjans@users.noreply.github.com> Date: Mon, 1 Jul 2024 16:11:28 +0530 Subject: [PATCH 2/3] Update L9-go-resolver-balancer-API.md --- L9-go-resolver-balancer-API.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/L9-go-resolver-balancer-API.md b/L9-go-resolver-balancer-API.md index af101792b..c000b59ca 100644 --- a/L9-go-resolver-balancer-API.md +++ b/L9-go-resolver-balancer-API.md @@ -53,7 +53,7 @@ gRPC first gets an address picked by the balancer. Balancer picks the address ba #### The balancing policy needs to be changed on service config updates -Upon service config updating, gRPC will look at the LoadBalancingPolicy field and decide which balancing policy to use. If the LoadBalancingPolicy specified by the service config is different from what's currently being used, gRPC should be able to change the policy. +Upon service config updating, gRPC will look at the LoadBalancingPolicy field and decide which balancing policy to use. If the LoadBalancingPolicy specified by the service config is different from what's currently being used, gRPC should be able to change the policy. Refer to [grpc-service-config](https://grpc.io/docs/guides/service-config/) for more details on this. Right now, there's no API to notify balancer of service config changes, so to change the balancing policy, the balancer needs to be swapped out. But swapping out the balancer and at the same time keeping the old resolver and address pool is not feasible because of the v1 structure. From 4f689b0d5c41a56ce15889ff4c88ebcc954edd9c Mon Sep 17 00:00:00 2001 From: Abhishek Ranjan <159750762+aranjans@users.noreply.github.com> Date: Fri, 26 Jul 2024 05:41:33 +0530 Subject: [PATCH 3/3] Update the lb config link --- L9-go-resolver-balancer-API.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/L9-go-resolver-balancer-API.md b/L9-go-resolver-balancer-API.md index c000b59ca..7b27dd1c2 100644 --- a/L9-go-resolver-balancer-API.md +++ b/L9-go-resolver-balancer-API.md @@ -53,7 +53,7 @@ gRPC first gets an address picked by the balancer. Balancer picks the address ba #### The balancing policy needs to be changed on service config updates -Upon service config updating, gRPC will look at the LoadBalancingPolicy field and decide which balancing policy to use. If the LoadBalancingPolicy specified by the service config is different from what's currently being used, gRPC should be able to change the policy. Refer to [grpc-service-config](https://grpc.io/docs/guides/service-config/) for more details on this. +Upon service config updating, gRPC will look at the LoadBalancingPolicy field and decide which balancing policy to use. If the LoadBalancingPolicy specified by the service config is different from what's currently being used, gRPC should be able to change the policy. Refer to [master/A24-lb-policy-config.md](https://github.com/grpc/proposal/blob/master/A24-lb-policy-config.md) for more details on this. Right now, there's no API to notify balancer of service config changes, so to change the balancing policy, the balancer needs to be swapped out. But swapping out the balancer and at the same time keeping the old resolver and address pool is not feasible because of the v1 structure.