Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Thread Check for Prefork/Postpork #38193

Open
chjasonwu opened this issue Nov 26, 2024 · 1 comment
Open

Remove Thread Check for Prefork/Postpork #38193

chjasonwu opened this issue Nov 26, 2024 · 1 comment

Comments

@chjasonwu
Copy link

Is your feature request related to a problem? Please describe.

I'm integrating Puma with gRPC and have encountered a thread consistency validation that occurs during prefork and postfork phases. I'm trying to understand the rationale behind this validation. I conducted load testing without this validation, and the application seemed to perform well.

This relates to the discussion in this thread: #8798 (comment).

Describe the solution you'd like

If removing this validation does not pose an operational risk, I propose eliminating it to ensure compatibility with Puma.

Describe alternatives you've considered

Another approach would be to ensure that Puma forks using the same thread to satisfy the validation. However, the necessity of this thread check for fork safety is unclear to me.

Additional context

n/a

@chjasonwu
Copy link
Author

cc @ytaben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants