Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSock support or examples of custom channels #2863

Open
payton opened this issue Dec 5, 2024 · 1 comment
Open

VSock support or examples of custom channels #2863

payton opened this issue Dec 5, 2024 · 1 comment

Comments

@payton
Copy link

payton commented Dec 5, 2024

Is your feature request related to a problem? Please describe.

I am interested in using @grpc/grpc-js for communication between an AWS Nitro Enclave and its host. There is a lightweight package for interfacing with VSock from node called https://github.com/wei-rong-1/node-vsock

Describe the solution you'd like

I would either like vsock support or an example of creating a custom Channel that could wrap the above referenced library.

Describe alternatives you've considered

The alternative to native support is creating a custom Channel that wrapps the node-vsock library.

@murgatroid99
Copy link
Member

I think it is unlikely that we will prioritize implementing built-in Vsock support in the foreseeable future. However, an implementation of Vsock support was contributed to the C++ gRPC implementation last year in grpc/grpc#33309, and the naming.md doc now has an official entry for the vsock target name scheme, so I would also be willing to accept a contribution of a conformant implementation in Node. However, the node-vsock library you referenced has a compiled Node extension, which I strongly want to avoid integrating into grpc-js, so a different vsock implementation would be needed to add it that way.

In addition, there is currently no way to create a custom channel that uses a node-vsock socket, but other gRPC implementations do have functionality that would allow that, so adding some functionality like that in this library is a reasonable possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants