Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health: Remove the fake petiole policy used for testing once round robin delegates to pickfirst #7906

Open
arjan-bal opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. P2 Type: Internal Cleanup Refactors, etc

Comments

@arjan-bal
Copy link
Contributor

As part of #7900, an alternate code path was added in the health check tests to use the new pickfirst with health listeners. This is required to have the existing health check tests run using the health producer, ensuring backward compatibility and providing test coverage for the changes in the PR. Once round robin delegates to pickfirst, we can revert the changes for adding the fake petiole policy and only test round robin.

@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Dec 6, 2024
@arjan-bal arjan-bal self-assigned this Dec 6, 2024
@arjan-bal arjan-bal added P2 Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. P2 Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

No branches or pull requests

1 participant