Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag lifted is broken --- remove? #209

Open
andreasabel opened this issue Nov 20, 2021 · 0 comments
Open

Flag lifted is broken --- remove? #209

andreasabel opened this issue Nov 20, 2021 · 0 comments
Labels
bug testing Concerning test suites and testing of `shelly`

Comments

@andreasabel
Copy link
Collaborator

The package has flag lifted to "run the tests against Shelly.Lifted":

Shelly.hs/shelly.cabal

Lines 98 to 100 in 4fe64d6

Flag lifted
Description: run the tests against Shelly.Lifted
Default: False

However, this probably hasn't been used in a long time. It is actually broken:

$ cabal build -f+lifted --enable-tests
Build profile: -w ghc-9.2.1 -O1
In order, the following will be built (use -v for more details):
 - shelly-1.9.0 (test:shelly-testsuite) (file test/src/TestInit.hs changed)
Preprocessing test suite 'shelly-testsuite' for shelly-1.9.0..
Building test suite 'shelly-testsuite' for shelly-1.9.0..
[ 4 of 15] Compiling RunSpec          ( test/src/RunSpec.hs, /Users/abel/bin/src/Shelly.hs/dist-newstyle/build/x86_64-osx/ghc-9.2.1/shelly-1.9.0/t/shelly-testsuite/build/shelly-testsuite/shelly-testsuite-tmp/RunSpec.o ) [flags changed]

test/src/RunSpec.hs:26:23: error:
    Variable not in scope: onCommandHandles :: t6 -> m0 T.Text -> Sh a9
   |
26 |       res <- shelly $ onCommandHandles (initOutputHandles (flip hSetBinaryMode True))
   |                       ^^^^^^^^^^^^^^^^

test/src/RunSpec.hs:26:41: error:
    Variable not in scope: initOutputHandles :: (Handle -> IO ()) -> t6
   |
26 |       res <- shelly $ onCommandHandles (initOutputHandles (flip hSetBinaryMode True))
   |                                         ^^^^^^^^^^^^^^^^^

test/src/RunSpec.hs:35:23: error:
    Variable not in scope: bash :: t5 -> [a7] -> Sh a8
   |
35 |       res <- shelly $ bash "echo" [ "wibble" ]
   |                       ^^^^
... ((ETC))

Should we remove it or let it keep rotting?

@andreasabel andreasabel added bug testing Concerning test suites and testing of `shelly` labels Nov 20, 2021
@andreasabel andreasabel added this to the 1.10 milestone Nov 20, 2021
@andreasabel andreasabel modified the milestones: 1.10, 1.10.0.1, 1.11 Jun 15, 2022
@andreasabel andreasabel removed this from the 1.11 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug testing Concerning test suites and testing of `shelly`
Projects
None yet
Development

No branches or pull requests

1 participant