Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide docker images for clients too #270

Open
micw opened this issue Feb 27, 2019 · 9 comments
Open

Please provide docker images for clients too #270

micw opened this issue Feb 27, 2019 · 9 comments

Comments

@micw
Copy link

micw commented Feb 27, 2019

Hello,
could you please add automated builds for the greenmail docker client images to docker hub?

Thank you very much,
Michael.

@derTobsch
Copy link
Contributor

I wanted to add the clients to our docker compose file so it is easier to look at the mails when developing. That would be awesome if they would be provided via docker hub.

@marcelmay
Copy link
Member

@derTobsch : I'm thinking about a separate GreenMail repo containing GreenMail + clients dockerized combinations.

@derTobsch
Copy link
Contributor

@marcelmay what would be the benefit if you would do that instead of keeping it in the same repo? If you separate it you need a job IMHO that updates the other repo after a release so you do not have to do that manually.

@JensKnipper
Copy link
Contributor

You might want to have a look at this docker-compose file:
https://github.com/JensKnipper/greenmail-example/blob/main/docker-compose.yml
If you need some explanation, I also wrote an article about it:
https://jensknipper.de/blog/greenmail-mock-mail-server-dev-setup/

There are also some examples in the repo:
https://github.com/greenmail-mail-test/greenmail/tree/master/greenmail-docker/clients
In my opinion they are not best practice anymore and should use the official clients' docker images.
I am going to create a pull request where this will be fixed soon. I am also going to adjust the documentation, so this part of the repo can be found easier in the future.

@marcelmay
Copy link
Member

Thx alot, @JensKnipper ! Added your article link to the docs and look forward to your PR.

Those docker clients were created usually only created for reproducing issues, and are not really maintained.

JensKnipper added a commit to JensKnipper/greenmail that referenced this issue Aug 30, 2021
JensKnipper added a commit to JensKnipper/greenmail that referenced this issue Aug 30, 2021
JensKnipper added a commit to JensKnipper/greenmail that referenced this issue Aug 30, 2021
JensKnipper added a commit to JensKnipper/greenmail that referenced this issue Aug 31, 2021
@JensKnipper
Copy link
Contributor

Hey @marcelmay,
thank you for linking my articles.

I am not finished yet, but I would like to discuss some things with you guys:

  • Roundcube: just finished, I hope you like the way i documented it - #270 use official roundcube docker image #414
  • Squirellmail:
    • dockerfile is not working anymore as Ubuntu 16 is out of support
    • squirrelmail is not in the repos of current Ubuntu versions anymore
    • the latest tag on svn is from 2011, not an option in my opinion
    • checking out the svn trunk might be an option
  • Rainloop
    • solidnerd's image as not been updated in 5 years
    • use his dockerfile to create new ones might be an option
  • Nodemailer:
    • not really a mail client, is this still needed?
    • I would suggest removing it

What do you think about that?

@marcelmay
Copy link
Member

@JensKnipper ,

thanks alot for the PR and your input.

  • Roundcube: Merged your PR.
  • Squirellmail, Rainloop: Any further PRs welcome.
  • NodeMailer: You're right, should not have ended up in the repo. Now its removed.

In general, I was thinking about moving these client integrations into new repo , eg https://github.com/greenmail-mail-test/greenmail-client-integrations (better name is open for suggestions). To keep the core repo more lean and focused.

marcelmay added a commit that referenced this issue Sep 3, 2021
@JensKnipper
Copy link
Contributor

Sounds good :)
The name also sounds good to me!

@marcelmay
Copy link
Member

Created https://github.com/greenmail-mail-test/greenmail-client-integrations/ and migrated roundcube/squirrelmail/rainloop.

Regarding SquirellMail, if the project is not maintained I think we should mark it as deprecated or drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants