Doc: add krb5-dev openvas dependency #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
|
Hi @jjnicola the community user in the mentioned scanner issue used a different release (23.14.0) compared to the version in the docs (23.8.2). Not sure if krb5-dev is already required for 23.8.2 and/or if you want to update the releases of the scanner components in the docs too? |
This comment was marked as resolved.
This comment was marked as resolved.
auto-merge was automatically disabled
January 15, 2025 13:31
Pull request was converted to draft
nichtsfrei
temporarily deployed
to
github-pages
GitHub Actions
Inactive
nichtsfrei
temporarily deployed
to
github-pages
GitHub Actions
Inactive
openvas-smb is not buildable with fedora anymore as the used heimdal
versions are too new.
This results in:
```
6.71 /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c: In function 'cli_credentials_set_from_ccache':
26.71 /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c:102:9: warning: 'krb5_princ_realm' is deprecated: Use X instead [-Wdeprecated-declarations]
26.71 102 | realm = krb5_princ_realm(cred->ccache->smb_krb5_context->krb5_context, princ);
26.71 | ^~~~~
26.71 In file included from /usr/include/heimdal/krb5.h:967,
26.71 from /workspaces/greenbone/openvas-smb/samba/lib/replace/system/kerberos.h:133,
26.71 from /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c:33:
26.71 /usr/include/heimdal/krb5-protos.h:6374:1: note: declared here
26.71 6374 | krb5_princ_realm (
26.71 | ^~~~~~~~~~~~~~~~
26.72 /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c: In function 'cli_credentials_get_client_gss_creds':
26.72 /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c:316:20: error: implicit declaration of function 'gss_krb5_import_cred'; did you mean 'gss_import_cred'? [-Wimplicit-function-declaration]
26.72 316 | maj_stat = gss_krb5_import_cred(&min_stat, ccache->ccache, NULL, NULL,
26.72 | ^~~~~~~~~~~~~~~~~~~~
26.72 | gss_import_cred
26.72 /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c: In function 'cli_credentials_set_client_gss_creds':
26.72 /workspaces/greenbone/openvas-smb/samba/auth/credentials/credentials_krb5.c:367:20: error: implicit declaration of function 'gss_krb5_copy_ccache' [-Wimplicit-function-declaration]
26.72 367 | maj_stat = gss_krb5_copy_ccache(&min_stat,
26.72 | ^~~~~~~~~~~~~~~~~~~~
26.72 gmake[2]: *** [samba/CMakeFiles/samba-static.dir/build.make:1470: samba/CMakeFiles/samba-static.dir/auth/credentials/credentials_krb5.c.o] Error 1
26.72 gmake[1]: *** [CMakeFiles/Makefile2:136: samba/CMakeFiles/samba-static.dir/all] Error 2
26.72 gmake: *** [Makefile:156: all] Error 2
```
when tested on fedora:latest -> fedora 41.
The test code is as follows:
```
RUN bash /source/.devcontainer/github-clone.sh greenbone/openvas-smb
RUN dnf install -y \
glib2-devel \
gnutls-devel \
popt-devel \
mingw64-gcc \
libunistring-devel \
heimdal-devel \
perl \
# missing on docs
libcom_err-devel
RUN PKG_CONFIG_PATH="/usr/lib64/heimdal/lib/pkgconfig:${PKG_CONFIG_PATH}" \
sh /source/.devcontainer/build-cmake-project.sh /workspaces/greenbone/openvas-smb
```
github-clone.sh can be found at:
https://github.com/greenbone/openvas-scanner/blob/dc44a8aa89e8016d09d6398ec80972e66d862aa1/.devcontainer/github-clone.sh
build-cmake-project can be found at:
https://github.com/greenbone/openvas-scanner/blob/dc44a8aa89e8016d09d6398ec80972e66d862aa1/.devcontainer/build-cmake-project.sh
nichtsfrei
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@bjoernricks made the version changes. Removed fedora from openvas-smb, because it doesn't compile. Check commit message for more details. |
|
@nichtsfrei could you please add the details of the changes to the https://github.com/greenbone/docs/blob/main/src/changelog.md file? sadly this document has still to be maintained manually. Additionally could you maybe case about updating the architecture regarding the scanner? it seems to be a bit outdated or even incorrect now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Doc: add krb5-dev openvas dependency
Doc: remove fedora from openvas-smb as it does not build anymore.
Close greenbone/openvas-scanner#1803
Why
missing dependency in openvas-scanner install documentation
References
Checklist