Add AGM CPLD to portapack detection routine #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossmann
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the AGM Microelectronics AG256SL100 to the portapack detection routine.
Almost all new portapacks are now made with the AGM CPLD. Without the ability to detect them in the stock hackrf firmware, users will just see a black screen and might think there is a defect as long as they didn't replace the firmware. So this should reduce user confusion and might even reduce support requests on both sides.
In the portapack firmware this fix is already injected into the "hackrf mode", but our compilation is somewhat messy now (can't just use your CMakeLists.txt).