Failure when saving signatures with Rizzo

[CreepNT]

When trying to save signatures from a PS2 ELF, located in a shared project, the script appears to run for a while then crashes with the following error :

RizzoSave.py> Running...
Building Rizzo signatures, this may take a few minutes...
Traceback (most recent call last):
  File "C:\Users\CreepNT\ghidra_scripts\RizzoSave.py", line 15, in <module>
    rizz = rizzo.Rizzo(currentProgram)
  File "__pyclasspath__/utils/rizzo.py", line 290, in __init__
  File "__pyclasspath__/utils/rizzo.py", line 612, in _generate
  File "__pyclasspath__/utils/rizzo.py", line 589, in _hash_function
  File "__pyclasspath__/utils/rizzo.py", line 556, in _hash_block
AttributeError: 'NoneType' object has no attribute 'isData'
RizzoSave.py> Finished!

As I would expect, no signature files are exported after this crash.

Ghidra Version : 9.2.2
Scripts located in C:\Users\CreepNT\ghidra_scripts

Any idea what could be cause this failure ? Maybe I'm missing a library ?

[fuzzywalls]

You shouldn’t be missing any libraries as all the scripts are self contained. Any chance you could attach the ELF in question or give me a link to it? I’ll look into it tonight (or more likely) early next week

[CreepNT]

Sure enough, thanks a lot for having a look.
SCUS_974.65

[CreepNT]

A thought just crossed my head :
since this is a PS2 ELF, I had to use a plugin that adds a format (namely Ghidra-EmotionEngine).

Could the issue be related to this ?

[fuzzywalls]

It could. I’ll include it in my testing, thanks.

[fuzzywalls]

@CreepNT I did some digging into the problem. I think it stems from a bad function in the Ghidra-EmotionEngine project, and put a ticket in for them to fix it (if it is actually a problem) here. In the mean time I made a fix to Rizzo that will allow you to use it as is. It shouldn't be a problem unless they fix the ticket I submitted, at that point you will probably need to regenerate your Rizzo signatures.

[CreepNT]

Just tried the updated version and it worked perfectly.
Thanks a for taking time to pinpoint and fix the issue.

[fuzzywalls]

No problem, thanks for letting me know