Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI does not log out the user automatically after the session expires #50431

Open
gzdunek opened this issue Dec 19, 2024 · 2 comments
Open
Labels

Comments

@gzdunek
Copy link
Contributor

gzdunek commented Dec 19, 2024

Web UI used to log out the user when it detected that the session is expired.

This what happens in dev tools (looks like we try to log out the user):
Image

I suspect this can be related to #43071.
Previously, we ignored any errors from api.delete() in session.logout(). Now, we redirect to the login page only if deleting the websession succeeds (which does not).

As a result, the user sees a 'missing session cookie' error everywhere in Web UI, and even clicking Logout has no effect.
The page needs to be reloaded manually with Cmd+R.

@gzdunek
Copy link
Contributor Author

gzdunek commented Dec 19, 2024

cc @rudream this may be related to the linked PR.

@zmb3
Copy link
Collaborator

zmb3 commented Dec 19, 2024

Let's add an item to the test plan for this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants