Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f64 and .exp() overflow very easily on large graphs #12

Open
daxpryce opened this issue Nov 2, 2020 · 0 comments
Open

f64 and .exp() overflow very easily on large graphs #12

daxpryce opened this issue Nov 2, 2020 · 0 comments

Comments

@daxpryce
Copy link
Contributor

daxpryce commented Nov 2, 2020

In our tests the code coming from CWTS' reference implementation for LocalMergingAlgorithm/subnetwork_clustering) our implementation ends up with f64/double overflows pretty easily. I want to go back and rig up a test to show just how frequently it can happen so we have an idea of the scale of the problem, and then also revisit whether we can pick a different function to apply to the qvi for a given join/merge rather than exponent.

Another option would be to normalize our weights to between 0 and 1 - our big problem now is that our weights are often a very large number in the hundreds of thousands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant