Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode code block ("CodeMirror") sections display a mysterious white square #1797

Open
bbaustin opened this issue Oct 19, 2024 · 0 comments

Comments

@bbaustin
Copy link

Description

When looking at the interactive code block (maybe called "CodeMirror") sections in dark mode, there is a white square that doesn't seem to do anything. I could see this on Chrome, Firefox, and Safari.

Steps to Reproduce

  1. Go to a page with an interactive code block (e.g., https://graphql.org/learn/queries/)
  2. You may see something like this:
Screenshot 2024-10-19 at 19 44 36

Expected Result

I would expect not to see the white square.

Actual Result

...I saw the white square.

Additional Context

There's a small chunk of CSS that sets this white square to be white:

.CodeMirror-scrollbar-filler,
.CodeMirror-gutter-filler {
  background-color: white; /* The little square between H and V scrollbars */
}

On light mode, this makes the square invisible (because the background is also white). However, this CSS doesn't seem to account for dark mode.

My proposed fix is a little lazy. I'll just make the square invisible on dark mode:

.CodeMirror-scrollbar-filler:is(html[class~=dark] *) ,
.CodeMirror-gutter-filler:is(html[class~=dark] *)  {
  background-color: transparent; /* The little square between H and V scrollbars */
}

I think that a larger fix might be ideal in the future, because the scrollbars are invisible anyway, so this square doesn't seem to have any use (see: #1617). But maybe my proposed fix is OK in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant