Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about demeaned covariates #48

Open
pedrohcgs opened this issue Oct 17, 2024 · 3 comments
Open

about demeaned covariates #48

pedrohcgs opened this issue Oct 17, 2024 · 3 comments

Comments

@pedrohcgs
Copy link

Hi @grantmcdermott

Thanks for all the work here. I am playing with the package, and I want to know if the std errors calculated in etwfe consider that the covariates' sample mean is random and estimated.

I mean, you are recentering all the covariates before you interact them, but are you treating the sample mean as the population mean? In the sampling approach adopted in Wooldridge, you would need to account for this extra randomness. But that would not be the case in the finite population setup a la Lin (2013).

Thanks again,
Pedro

@grantmcdermott
Copy link
Owner

grantmcdermott commented Oct 21, 2024

Sorry for the slow reply @pedrohcgs . You caught me while I was away....

Oof. Honestly, it's been a while since I looked at this code, but the short answer is 'no'. I didn't do any special adjustments for sampling error. (I seem to recall Jeff Wooldridge asking me about this back when I first released the package.) I'm trying to remember now, but I don't think jwdid does this adjustment either and I was initially benchmarking my results against this latter package. OTOH, I also did some benchmarking against Wooldridge's manual implementation and IIRC my standard errors and his were typically equivalent until 4 significant digits. So I'm not sure that it will make much difference in practice, if we're already accounting for clustering etc. (Could be wrong!)

I'm currently juggling few other OSS projects (outside of "office hours" unfortunately). But I'll aim to take a deeper look at this when I can. Appreciate any additional thoughts you might have, though ;-)

@grantmcdermott
Copy link
Owner

Quick update: I believe that this requires an adjustment (or allowance for manual adjustments) on the marginaleffects side. Tracking upstream: vincentarelbundock/marginaleffects#1240

@pedrohcgs
Copy link
Author

pedrohcgs commented Oct 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants