From feafa26ef95c5cdf9ddc8ff90c9349098859fc23 Mon Sep 17 00:00:00 2001 From: Ankur Date: Fri, 15 Dec 2023 09:28:54 +0000 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: İnanç Gümüş --- tests/remote_obj_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/remote_obj_test.go b/tests/remote_obj_test.go index 0b6d92319..abbf20a0a 100644 --- a/tests/remote_obj_test.go +++ b/tests/remote_obj_test.go @@ -135,7 +135,7 @@ func TestEvalRemoteObjectParse(t *testing.T) { name: "filled_object", eval: `{return {foo:"bar"};}`, want: map[string]any{"foo": "bar"}, }, { - name: "filled_array", eval: `{return ["foo","bar"];}`, want: []interface{}{0: "foo", 1: "bar"}, + name: "filled_array", eval: `{return ["foo","bar"];}`, want: []any{0: "foo", 1: "bar"}, }, { name: "filled_array", eval: `() => true`, want: `function()`, @@ -161,6 +161,7 @@ func TestEvalRemoteObjectParse(t *testing.T) { { name: "scientific_notation", eval: "123e-5", want: 0.00123, }, + // TODO: // { // // This test is ignored until https://github.com/grafana/xk6-browser/issues/1132 // // has been resolved.