Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunksCache PDB is not user configurable despite a values value #13989

Open
tico24 opened this issue Aug 28, 2024 · 0 comments · May be fixed by #15531
Open

chunksCache PDB is not user configurable despite a values value #13989

tico24 opened this issue Aug 28, 2024 · 0 comments · May be fixed by #15531
Labels
type/feature Something new we should do

Comments

@tico24
Copy link
Contributor

tico24 commented Aug 28, 2024

Describe the bug
The values file contains:

chunksCache:
    # -- Pod Disruption Budget
    podDisruptionBudget:
      maxUnavailable: 1

https://github.com/grafana/loki/blob/main/production/helm/loki/values.yaml#L3015

The PDB template has maxUnavailable hard coded to 1, so it doesn't matter what you change this value to.
https://github.com/grafana/loki/blob/main/production/helm/loki/templates/chunks-cache/poddisruptionbudget-chunks-cache.yaml#L15

To Reproduce
Steps to reproduce the behavior:

  1. Change chunksCache.podDisruptionBudget.maxUnavailable to 100
  2. See that the resulting PDB doesn't change

Expected behavior
I expect to be able to control the values within the templates by completing the values in values.yaml

Environment:

  • Infrastructure: [e.g., Kubernetes, bare-metal, laptop] k8s
  • Deployment tool: [e.g., helm, jsonnet] helm

Screenshots, Promtail config, or terminal output
If applicable, add any output to help explain your problem.

@JStickler JStickler added the type/feature Something new we should do label Oct 28, 2024
@sule26 sule26 linked a pull request Dec 21, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Something new we should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants